Repository navigation
Conversation
e142b0d to
22d3460
Compare
38137c4 to
efcc5ca
Compare
|
Thanks for consolidating Reason: live combos on this host still pin Purpose of the recut: ship current |
3399c9c to
30b33ab
Compare
#13248) Merged after renumbering. `176_provider_connection_synced_models_at.sql` collided with `176_xp_action_counts.sql` (#12651), which made the migration runner abort on every DB open. Renamed to **177**; the doc count moves 173 → 174 across README.md, AGENTS.md, llm.txt and the i18n mirrors (operator-approved, 206 numeric substitutions and nothing else). - `check:migration-numbering`: OK, 174 migrations, no duplicates - `check:docs-counts` migrations: ✓ - 84/84 across the NVIDIA suite plus the seven DB-touching suites the collision had taken down - ESLint and `typecheck:core`: exit 0 Heads-up for whoever lands next: **177 is claimed by eight other open PRs** (#13610, #13602, #13580, #13554, #13405, #13331, #13177, #13116) and 176 by #13373 and #13102. With this merged, all of them need to renumber at merge time — `check:migration-numbering` forbids new gaps, so the next free number is always the only valid one.⚠️ base-red inherited: #12732
|
This is a genuinely large architectural proposal — folding the |
|
Direction check — full consolidation vs shared catalog @diegosouzapw — capturing the trade-off so we can close this one way or the other: This PR (full consolidation) — one Merged #13410 (shared catalog) — keeps both provider ids and shares one model list ( My position — why I want the two merged: I've been watching these two surfaces for a long time, and I've concluded there is no benefit at all in keeping them coexisting. The desktop and CLI versions use exactly the same models, tools and call logic — even the login flow is identical: if login fails on the CLI it fails on the desktop version too, and vice versa. There is no reason to keep unnecessary duplication and raise the code's complexity. I fully understand that people who have been using them may feel inconvenienced, but I believe a decisive move now — cut the complexity and keep only the essential surface — is the better trade, and it is what ultimately reduces user confusion rather than adding to it. The mechanics back this up: Either way I will do the work:
#12608 has now been rewritten on top of Production constraint worth recording: @HouMinXi kept |
30b33ab to
b63509f
Compare
|
Restacked and rebased onto today's tree —
The direction question from my previous comment still stands (@diegosouzapw) — the branch is now clean and ready for review either way. |
b63509f to
6d72002
Compare
ca3f3ff to
0bc133d
Compare
c2066b2 to
c092956
Compare
|
Re-homed to |
…avity and AGY catalogs Rewritten on top of the now-current shared antigravitySharedModels.ts catalog (cheaper-inference#13410) and the merged 3.8 Flash direct-tier work (cheaper-inference#13318) instead of the stale duplicate googleCloudCodeModelCatalog.ts from the previous round. - Drop the retired 3.7 blocks from the shared catalog; keep the 3.6/3.7 ids in the retired sets so stale upstream discovery entries stay hidden. - Keep the live-verified 3.8 direct-tier mapping: -high/-medium/-low pass through verbatim and the bare display id aliases to -high. - Antigravity CLI fallback signature bumps to 1.2.3 and CLI_TOOLS/free-model metadata follow the 3.8 tiers. - AGY gains the same non-chat pattern filter as Antigravity. - Keeps the merged live-catalog-authoritative discovery policy.
…ider Merge the standalone agy provider into antigravity and delete the IDE client identity. Both clients authenticate against the same Google consumer-OAuth client and share the Cloud Code backend, model catalog, and quota, so the provider now presents only the official CLI fingerprint. - delete the agy registry entry, agyModels.ts, AGY_CONFIG and the agy OAuth provider; agy stays a runtime alias for old URLs and agy/<model> ids - remove the IDE User-Agent/release-feed paths and the per-connection client-profile selector; AntigravityClientProfile is now cli only - migrate stored agy rows to antigravity and normalize the legacy IDE profile (migration 176) - sync the provider count to 355 (README/AGENTS/llm.txt/package.json) and regenerate PROVIDER_REFERENCE plus the SVG canonical numbers - dashboard: a single Antigravity card carrying the CLI import hint
…dated provider The agy provider id no longer receives family-scoped lock keys after the CLI consolidation; assert the exact-model scope instead.
The stack carried A's 1.2.0 assertions next to C's earlier 1.1.5 seeds; unify on 1.2.0 so the seeded cache matches the pinned regex.
…c the branch counts The consolidation migration lands as 179 on the current release tree (178 is the current max); refresh PROVIDER_REFERENCE, the doc/SVG canonical counts (357 providers, 21 OAuth providers) and the llm.txt mirrors for the merged catalog.
…policy and CLI identity - Antigravity discovery stays live-authoritative (cheaper-inference#13410): unknown chat tiers remain discoverable, retired 3.7-era ids stay hidden, and callable compatibility aliases keep their upstream echoes. - Antigravity quota keys keep the existing callable-model policy (the strict path that predates the merge). - Usage-service, bootstrap and weekly-quota tests now expect the CLI-only fingerprint (antigravity/cli/1.2.3); shared-catalog tests no longer import the deleted agyModels module.
…c the refreshed counts Upstream migrations now run through 189 (quota schedules), so the consolidation migration moves to 190; the merged state is 357 providers / 187 migrations. PROVIDER_REFERENCE regenerated, the README/AGENTS/llm.txt/package.json counts and the diagram SVGs re-synced, and the 66 llm.txt locale mirrors rebuilt from the root file. No functional change.
|
Hi @backryun — closing this pull request to clear the open queue. The branch |
|
Hi @backryun — reopening this pull request. The close was a mistake, and it is back in the merge queue. The branch |
|
Re-homed to |
|
Thanks @backryun, this is thorough work and the migration/ACL/alias handling is clearly thought through. It is being held for one reason: the direction decision (full agy->antigravity consolidation vs the shared-catalog approach that landed in #13410) is a maintainer call that has not been made yet, and it removes a provider id users and combos may pin. Separately, whichever way it goes, the branch will need a fresh rebase: #12608 is already merged (so those commits conflict), the tip's antigravity executor/verification code moved, ~37 non-docs files conflict, and migration number 197 is taken (the tip is at 212 now). Also please keep AGENTS.md/llm.txt out of the PR (or leave them to the maintainers, they are protected files) and leave the 12608 changelog fragment untouched. If the call is 'keep shared catalogs', the non-breaking parts (client identity/version alignment) as a smaller PR would be very welcome. We will keep you credited on anything we use. |
|
Thank you for the work on this, @backryun — consolidating We have decided to keep So I'm closing this one. If you see duplication that is still left between the two providers, a smaller PR focused on that would be very welcome. |
Summary
Consolidate standalone
agyintoantigravitywith the official CLI client identity. Existingagy/model IDs, credential imports, and/api/oauth/agy/{action}URLs remain compatible; new OAuth exchanges save canonical Antigravity connections.197_merge_agy_into_antigravity.sqlkeeps canonical unique-key winners and unmatched legacy rows, credentials, defaults, combos, aliases, limits, and discovery settings. Legacy ACL spellings remain and canonical equivalents are appended so both grants and restrictions continue to work.blocked_modelsfallback before migrations run so fresh DB initialization succeeds, reusingAPI_KEY_COLUMN_FALLBACKSand preserving persistent/in-memory schema-healing order.Base and review direction
Based on
release/v3.8.52at23a11484862b3bb589a55e85b00e4ac53ffeb234(2026-10-03), stacked on #12608 headb852852d339da12f871d76f445a8e82ab2496e8f. Review that catalog change first. The maintainer still needs to choose between separate shared-catalog providers and full consolidation.AGENTS.mdchanges are limited to measured provider/migration counts.Validation
Official per-worker-isolated Node batch: 729/729 across 69 affected files.
Prior CI regressions reproduced before the fix; all 76 focused regression tests now pass. Migration collision/ACL/idempotence/fresh-core tests: 4/4; existing core-init tests: 14/14; legacy OAuth route regressions: 3/3.
Affected quota-family Vitest suite: 7/7.
Core typecheck, full lint, active commit hooks, provider consistency/assets, model lifecycle, file-size limits, cycle ratchet, migration numbering, strict mutation test-list coverage, and
check:docs-all: passed.Reconciled all 66 README and 66 provider-reference translations with the measured source facts and recorded their hashes using the scoped translation-adopt workflow. Updated technical notes use a limited canonical-English fallback where a translated clause could not be safely retained. Strict translation validation reports only the independently reproduced base drift in
QUALITY_GATES.md.Exact-base
check:test-maskingpasses. Nine reviewed net-count exceptions document removed IDE/profile or duplicate AGY contracts; the deleted standalone AGY provider suite has canonical-provider, migration, legacy OAuth and prefix-lookup replacement coverage. Skip/tautology/deletion checks remain enforced. Final affected follow-up suites: 69/69; legacy quota assertions explicitly cover both exhausted Claude and available Gemini.Exact-base validation limits
The unmodified base independently reproduces strict-core TS7006 at
autoStrategy.ts:519, the AgentRouter/Claudecli/sdk-cligolden snapshot drift, the dependency audit failure that stops the CI Lint job, stale generatedskills/omni-providers/SKILL.md, and strict documentation-translation drift fordocs/architecture/QUALITY_GATES.md. The generated-skill failure was reproduced from a pure archive of the base. The old unused-suppression and missing-Stryker-test-list failures are resolved in this base. Wider release CI failures are tracked in #15306; current-head CI results remain authoritative.