Repository navigation
test(batches): boot the batch E2E suite through the peer-stamped server (base-red #14547) - #14718
Merged
Merged
Conversation
diegosouzapw
added a commit
that referenced
this pull request
Sep 24, 2026
All three fail on the release tip (fast-path shards 3/4 and 4/4 of #14718, a PR that touches none of their subjects) and no open base-red PR covers them. Each follows an intentional product change that merged without its guard: - responses-handler: #14572 (#14330) gave the synthesized response.in_progress keepalive a sequence_number and response object; the assertion now pins the full compliant frame instead of the bare one. - check-vitest-exclusions: #14493 repaired every quarantined suite and emptied the inventory; the live-config test still fails on any exclusion the inventory does not list, so the non-empty check was the only stale part. - perf-waterfall-elimination: #14421 routes the Home settings read through loadHomeSettings() (defaults to getSettings); the test still requires it in the same Promise.all batch, before getMachineId, with no serial await. 28/28 on the idle .113. Refs #14547
diegosouzapw
changed the title
diegosouzapw
force-pushed
the
fix/release-v3.8.51-basereds-r4
branch
from
September 24, 2026 13:35
43866ed to
1fdabd2
Compare
diegosouzapw
added a commit
that referenced
this pull request
Sep 24, 2026
All three fail on the release tip (fast-path shards 3/4 and 4/4 of #14718, a PR that touches none of their subjects) and no open base-red PR covers them. Each follows an intentional product change that merged without its guard: - responses-handler: #14572 (#14330) gave the synthesized response.in_progress keepalive a sequence_number and response object; the assertion now pins the full compliant frame instead of the bare one. - check-vitest-exclusions: #14493 repaired every quarantined suite and emptied the inventory; the live-config test still fails on any exclusion the inventory does not list, so the non-empty check was the only stale part. - perf-waterfall-elimination: #14421 routes the Home settings read through loadHomeSettings() (defaults to getSettings); the test still requires it in the same Promise.all batch, before getMachineId, with no serial await. 28/28 on the idle .113. Refs #14547
The suite seeds a provider node and mints an API key via the management API in open bootstrap mode. That window stays open only for a loopback peer, and locality comes from the TCP-peer stamp that only the custom server in run-next.mjs writes. Booted through run-next-playwright.mjs (bare next dev) it got 401 on POST /api/provider-nodes before any assertion ran - red on the release tip db70929 on the idle .113, also before #14472. Same trap #11535 and #14403 fixed in the protocol and ecosystem harnesses. Integration only runs on the release PR, so a unit source-contract test now pins the boot target where every PR sees it. Fixed suite: 2/2 green on the same box. Refs #14547
diegosouzapw
force-pushed
the
fix/release-v3.8.51-basereds-r4
branch
from
September 25, 2026 08:08
1fdabd2 to
9a76968
Compare
diegosouzapw
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tests/integration/batch-e2e-rate-limit.test.tsfails on the release tip (db70929330, and already before #14472) withFailed to create provider node: 401 null, before any assertion runs. No open PR covers it.The suite seeds a provider node and mints an API key through the management API in open bootstrap mode. That window stays open only for a loopback peer, and locality comes from the TCP-peer stamp that only the custom server in
scripts/dev/run-next.mjswrites. The suite bootedrun-next-playwright.mjs(barenext dev), which never stamps the peer, so the calls failed closed. #11535 fixed the same trap in the protocol-clients harness and #14403 in the ecosystem harness; this is the third one.Change
tests/integration/batch-e2e-rate-limit.test.ts: bootrun-next.mjs dev(HOST stays pinned to127.0.0.1, open bootstrap unchanged). No assertion touched.tests/unit/batch-e2e-server-stamping.test.ts: source contract pinning the boot target, loopback host and open bootstrap. Integration only runs on the release PR, so this is where every PR sees a regression.Validation
e60b01e818, the parent of fix(auth): unblock fresh Docker installs from the onboarding loop with a one-shot bootstrap token (#14296) #14472).Update (2026-09-25)
The three stale unit guards this PR also realigned (
responses-handler,check-vitest-exclusions,perf-waterfall-elimination) were realigned the same way by #14511, which merged first. That commit was dropped on rebase, so this PR is now only the batch E2E boot fix.Other reds on the tip, and who owns them
Measured on
db70929330on the idle .113:typecheck:corecliproxyAccountHealth.tsTS2322,DEEP_HEALTH_CHECK_ENABLEDmissing from.env.exampleauggie.ts×8,projectCombo.ts×3check-deps@opencode/pluginagent-bridge-cert-flowPOST /cert400≠404All four owning PRs are currently
DIRTYagainst the tip.