[Dattuog]

Summary

• Fix inherited core and dashboard typecheck errors: external CLIProxyAPI management defaults to loopback, and valid weight patches are narrowed before spreading.
• Document DEEP_HEALTH_CHECK_ENABLED in both environment references; prune stale ESLint suppressions.

Related Issues

Related to #14547. Kept separate from the catalog feature PR.

Validation

• Change type: other (release quality repair)
• Focused tests and category gates
• npm run lint
• Reconciled with release/v3.8.51 at 18bbb1019
• Production change includes a test

npm run typecheck:core                    exit code 0
npm run check:dashboard-typecheck         OK (no new errors)
npm run check:docs-all                    exit code 0
npm run lint                              exit code 0
cliproxy-account-health.test.ts           6 pass, 0 fail
intelligent-routing-weight-edit.test.ts  4 pass, 0 fail

Tests Added Or Updated

• tests/unit/services/cliproxy-account-health.test.ts: external management key without host uses loopback.

Coverage Notes

The new test covers the CLIProxyAPI external-host fallback. Existing weight-edit tests cover the routing patch.

Reviewer Notes

The deep health probe remains opt-in. No migrations or secrets. ESLint generated the suppression cleanup.

[gonisulaimann]

Heads-up: this went DIRTY against release/v3.8.51 after yesterday's merge wave (db70929). Merging the upstream tip into the branch should clear it — happy to verify once updated. Once this and #14717 land, the docs-gate cluster from #14547 (migration count + DEEP_HEALTH_CHECK_ENABLED) is fully green for every PR.

[Dattuog]

Thanks for the heads-up. I merged the current release/v3.8.51 tip (a1baae7) into this branch in c512586. The PR is mergeable again. The merge retains upstream’s routing type fix and combines both ESLint suppression cleanups; the resulting diff contains five intended files. The new GitHub Actions runs still need maintainer approval before CI can execute.

[diegosouzapw]

Thanks for tracking down the two typecheck regressions — both fixes are correct. I found
that they're already covered, nearly line-for-line, by two maintainer PRs already in
flight: #14511 (cliproxyAccountHealth.ts loopback fallback) and #14520
(intelligentRouting.ts weight-patch narrowing), and both of those also add the
DEEP_HEALTH_CHECK_ENABLED docs entry you added here. To avoid a three-way conflict on
eslint-suppressions.json, I'm marking this as covered by #14511+#14520 rather than
merging it separately — once those land I'll follow up here in case anything in your diff
wasn't actually covered.

[diegosouzapw]

Thanks @Dattuog for working on the release typecheck and env-doc reds. Both code fixes and the docs fix are already on release/v3.8.51:

• src/lib/services/cliproxyAccountHealth.ts falls back to loopback (externalHost || "127.0.0.1") when only the management key is set. This landed with fix(ci): drain the release/v3.8.51 base-reds — auggie/projectCombo typecheck + three stale catalog guards (#14496) #14511.
• src/lib/combos/intelligentRouting.ts narrows the weight patch (weightPatch) before the spread, which fixes the TS2698 error. This landed with fix(types): preserve narrowed intelligent routing weights #14503.
• DEEP_HEALTH_CHECK_ENABLED is now documented in .env.example and docs/reference/ENVIRONMENT.md, also through fix(ci): drain the release/v3.8.51 base-reds — auggie/projectCombo typecheck + three stale catalog guards (#14496) #14511.

That leaves the prune of stale entries in config/quality/eslint-suppressions.json. That file changes on almost every merge, so this diff conflicts. If any of those suppressions are still stale on the current tip, a small follow-up PR against release/v3.8.51 that removes only those entries would be welcome. I'm closing this one as covered. Thank you!