Skip to content

test(ui): repair and retire all six quarantined suites - #14493

Merged
diegosouzapw merged 1 commit into
release/v3.8.51from
fix/qg10-quarantine-retirement-20260922
Sep 24, 2026
Merged

test(ui): repair and retire all six quarantined suites#14493
diegosouzapw merged 1 commit into
release/v3.8.51from
fix/qg10-quarantine-retirement-20260922

Conversation

@diegosouzapw

@diegosouzapw diegosouzapw commented Sep 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Scope

Stacked on #14426. Repairs and returns all six quarantined files to the normal UI test collector; the exclusion inventory becomes empty. No expiry extension, threshold reduction, production mock replacement or dropped assertion.

  • Move the three cache suites under tests/unit/ui/cache/ and load their DOM assertion matchers.
  • Align cache fixtures with the actual typed trends response; disambiguate repeated values by their rendered widget.
  • Supply AgentCard's required server state and unmount React roots after tests.
  • Import page modules during collection, preserving the default-component assertions without charging module transformation to the five-second test timer.
  • Pin the quarantine workflow's new actions and disable dependency caching for its scheduled execution.

Evidence

  • Previous measured quarantine: 31 failing / 15 passing tests across six files.
  • Repaired components: 44/44; page import smokes: 2/2.
  • Replayed via normal vitest.config.ts: 50/50 in seven files (the six repaired files plus the adjacent four-test cache-settings suite selected by the path).
  • Discovery/exclusion/expiry contracts: 29/29.
  • check-test-discovery: 6155 files, 32 collectors, zero quarantined files. Nine already-frozen orphan files remain separate debt.
  • actionlint and the repository commit hooks passed. No baseline was changed.

Local focused runs used the available Vitest 4.1.11 tooling. The lockfile-pinned Vitest 5 CI on the combined candidate remains required; this draft is not full release acceptance.

Resgate para release/v3.8.51 (merge-batch 2026-09-23)

Esta PR estava empilhada sobre fix/qg10-quarantine-contract-20260922 (#14426), que não vai para a release. A base foi trocada para release/v3.8.51 e o branch foi reconstruído a partir do tip da release (adefe4f5).

  • Carregado: cc9201a9 "test(ui): repair and restore all quarantined component suites", re-aplicado como 0fb779f1 (o único commit próprio desta PR).
  • Ficou na pilha (ci: make quarantined test debt bounded and executable #14426, não entra): o inventário/contrato de quarentena (campos owner/expires), vitest.quarantine.config.ts e o workflow .github/workflows/test-quarantine.yml.
  • Conflitos resolvidos:
    • .github/workflows/test-quarantine.yml: descartado, porque o arquivo só existe em ci: make quarantined test debt bounded and executable #14426.
    • config/quality/vitest-exclusions.json: a versão da release já tem o inventário (sem owner/expires). O resgate zera excluded: [], e check:vitest-exclusions passa com "0 excluded file(s)".
  • Diff final contra a release: 8 arquivos. São os reparos das 6 suítes, os 3 testes de cache movidos para tests/unit/ui/cache/, as exclusões retiradas do vitest.config.ts e o inventário zerado.
  • Validação:
    • Com o resgate, npx vitest run --config vitest.config.ts nas 6 suítes deu 46/46 (6/6 arquivos).
    • No tip, as 6 estão excluídas: vitest responde "No test files found". Com as exclusões removidas, o tip dá 31 failed / 15 passed (46).
    • Com load médio de 44 a 68 no devbox, duas rodadas tiveram falha transitória: uma de resolução de módulo react/jsx-runtime e 1 teste. Isoladas e com a carga menor, deram verde duas vezes seguidas.

@diegosouzapw
diegosouzapw changed the base branch from fix/qg10-quarantine-contract-20260922 to release/v3.8.51 September 24, 2026 00:57
@diegosouzapw
diegosouzapw force-pushed the fix/qg10-quarantine-retirement-20260922 branch from cc9201a to 0fb779f Compare September 24, 2026 00:57
@diegosouzapw
diegosouzapw marked this pull request as ready for review September 24, 2026 00:57
diegosouzapw added a commit that referenced this pull request Sep 24, 2026
@diegosouzapw
fix(auth): restore keyless local-first posture on GET /v1/models (#13354
e60b01e 
) (#14415)

Merge-batch 2026-09-23 (PRs do mantenedor, Trilha B, retrabalhada).

Um worker corrigiu o defeito apontado na revisão direto no branch da PR; o detalhe está na seção "Rework (merge-batch 2026-09-23)" do corpo, com a prova de red→green. Revalidado numa árvore combinada das PRs da 2ª leva da Trilha B (#14415 #14472 #14468 #14493 #14403) sobre o tip atual de `release/v3.8.51`:
- 104/104 testes node focados + 46/46 vitest (as 6 suítes de UI que saíram da quarentena); `check:provider-consistency` OK (359)
- `typecheck:core`: só o herdado `cliproxyAccountHealth.ts:157`; `check:open-sse-typecheck`: só o herdado `auggie.ts` (base-red #14547, corrigido pela #14511)
- eslint nos arquivos alterados limpo; file-size OK
diegosouzapw added a commit that referenced this pull request Sep 24, 2026
@diegosouzapw
fix(auth): unblock fresh Docker installs from the onboarding loop wit…
43b6eeb 
…h a one-shot bootstrap token (#14296) (#14472)

Merge-batch 2026-09-23 (PRs do mantenedor, Trilha B, retrabalhada).

Um worker corrigiu o defeito apontado na revisão direto no branch da PR; o detalhe está na seção "Rework (merge-batch 2026-09-23)" do corpo, com a prova de red→green. Revalidado numa árvore combinada das PRs da 2ª leva da Trilha B (#14415 #14472 #14468 #14493 #14403) sobre o tip atual de `release/v3.8.51`:
- 104/104 testes node focados + 46/46 vitest (as 6 suítes de UI que saíram da quarentena); `check:provider-consistency` OK (359)
- `typecheck:core`: só o herdado `cliproxyAccountHealth.ts:157`; `check:open-sse-typecheck`: só o herdado `auggie.ts` (base-red #14547, corrigido pela #14511)
- eslint nos arquivos alterados limpo; file-size OK
diegosouzapw added a commit that referenced this pull request Sep 24, 2026
@diegosouzapw
fix(providers): retire the suno music provider (#14224) (#14468)
4af4937 
Merge-batch 2026-09-23 (PRs do mantenedor, Trilha B, retrabalhada).

Um worker corrigiu o defeito apontado na revisão direto no branch da PR; o detalhe está na seção "Rework (merge-batch 2026-09-23)" do corpo, com a prova de red→green. Revalidado numa árvore combinada das PRs da 2ª leva da Trilha B (#14415 #14472 #14468 #14493 #14403) sobre o tip atual de `release/v3.8.51`:
- 104/104 testes node focados + 46/46 vitest (as 6 suítes de UI que saíram da quarentena); `check:provider-consistency` OK (359)
- `typecheck:core`: só o herdado `cliproxyAccountHealth.ts:157`; `check:open-sse-typecheck`: só o herdado `auggie.ts` (base-red #14547, corrigido pela #14511)
- eslint nos arquivos alterados limpo; file-size OK
@diegosouzapw
diegosouzapw merged commit 2697760 into release/v3.8.51 Sep 24, 2026
8 of 10 checks passed
diegosouzapw added a commit that referenced this pull request Sep 24, 2026
@diegosouzapw
fix(test): boot ecosystem through trusted-peer server (#14403)
db70929 
Merge-batch 2026-09-23 (PRs do mantenedor, Trilha B, retrabalhada).

Um worker corrigiu o defeito apontado na revisão direto no branch da PR; o detalhe está na seção "Rework (merge-batch 2026-09-23)" do corpo, com a prova de red→green. Revalidado numa árvore combinada das PRs da 2ª leva da Trilha B (#14415 #14472 #14468 #14493 #14403) sobre o tip atual de `release/v3.8.51`:
- 104/104 testes node focados + 46/46 vitest (as 6 suítes de UI que saíram da quarentena); `check:provider-consistency` OK (359)
- `typecheck:core`: só o herdado `cliproxyAccountHealth.ts:157`; `check:open-sse-typecheck`: só o herdado `auggie.ts` (base-red #14547, corrigido pela #14511)
- eslint nos arquivos alterados limpo; file-size OK
diegosouzapw added a commit that referenced this pull request Sep 24, 2026
@diegosouzapw
test(quality): allow the empty vitest-exclusions inventory #14493 rea…
a8550be 
…ched

#14493 restored every quarantined component suite, leaving excluded: [] — the
target state — but the inventory test still demanded a non-empty list. An
exclusion added without an inventory entry stays caught by the live-config
case.

Refs #14496
diegosouzapw added a commit that referenced this pull request Sep 24, 2026
@diegosouzapw
test: realign three unit guards with #14572, #14493 and #14421
43866ed 
All three fail on the release tip (fast-path shards 3/4 and 4/4 of #14718, a
PR that touches none of their subjects) and no open base-red PR covers them.
Each follows an intentional product change that merged without its guard:

- responses-handler: #14572 (#14330) gave the synthesized
  response.in_progress keepalive a sequence_number and response object; the
  assertion now pins the full compliant frame instead of the bare one.
- check-vitest-exclusions: #14493 repaired every quarantined suite and
  emptied the inventory; the live-config test still fails on any exclusion the
  inventory does not list, so the non-empty check was the only stale part.
- perf-waterfall-elimination: #14421 routes the Home settings read through
  loadHomeSettings() (defaults to getSettings); the test still requires it in
  the same Promise.all batch, before getMachineId, with no serial await.

28/28 on the idle .113.

Refs #14547
@diegosouzapw diegosouzapw mentioned this pull request Sep 24, 2026
Merged
@adivekar-utexas adivekar-utexas mentioned this pull request Sep 24, 2026
Merged
adivekar-utexas added a commit to adivekar-utexas/OmniRoute that referenced this pull request Sep 24, 2026
@adivekar-utexas
chore: clear release-branch drift blocking PR CI
b097d06 
Four independent pieces of release-branch drift were red on every PR to
release/v3.8.51, none of them caused by this PR. Fixing each per what its own
gate message prescribes:

- .env.example + docs/reference/ENVIRONMENT.md: document DEEP_HEALTH_CHECK_ENABLED
  (read by src/app/api/monitoring/health/route.ts) — check:env-doc-sync reported
  'In code but missing from .env.example: 1'.
- config/quality/dependency-allowlist.json: allowlist @opencode/plugin (npm v2.0.16,
  publisher thdxr <d@ironbay.co>, the opencode maintainer). The pre-existing
  @opencode-ai/plugin entry is the old scope; upstream renamed it. Verified against
  the registry before allowlisting, per check:deps' human-review requirement.
- tests/unit/check-vitest-exclusions.test.ts: drop the 'inventory is not empty'
  fixture precondition. vitest-exclusions.json's excluded:[] is the healthy end state
  after cheaper-inference#14493 returned all six quarantined files to normal discovery, so the
  assertion is stale; the per-entry loop already validates whatever entries exist.
diegosouzapw added a commit that referenced this pull request Sep 24, 2026
@diegosouzapw
test: realign three unit guards with #14572, #14493 and #14421
1fdabd2 
All three fail on the release tip (fast-path shards 3/4 and 4/4 of #14718, a
PR that touches none of their subjects) and no open base-red PR covers them.
Each follows an intentional product change that merged without its guard:

- responses-handler: #14572 (#14330) gave the synthesized
  response.in_progress keepalive a sequence_number and response object; the
  assertion now pins the full compliant frame instead of the bare one.
- check-vitest-exclusions: #14493 repaired every quarantined suite and
  emptied the inventory; the live-config test still fails on any exclusion the
  inventory does not list, so the non-empty check was the only stale part.
- perf-waterfall-elimination: #14421 routes the Home settings read through
  loadHomeSettings() (defaults to getSettings); the test still requires it in
  the same Promise.all batch, before getMachineId, with no serial await.

28/28 on the idle .113.

Refs #14547
@diegosouzapw
diegosouzapw deleted the fix/qg10-quarantine-retirement-20260922 branch October 18, 2026 23:50
Witroch4 pushed a commit to Witroch4/OmniRoute that referenced this pull request Oct 24, 2026
Wital @claude
test(ui): adopt upstream's repaired cache suites and load jest-dom in…
b4faa00 
… the discovery suite

With @testing-library/dom installed the six remaining RTL suites load. Three
cache component suites (CachePerformance, CacheTrends, IdempotencyLayer) still
asserted an old markup; upstream repaired them and moved them to
tests/unit/ui/cache/ in cheaper-inference#14493 (2697760). Those versions pass 40/40 against
the fork's components, so they replace the stale copies. DiscoveryPageClient
used jest-dom matchers without importing them.

vitest.config.ts: 244 files / 1734 tests green (was 51 failing files).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@diegosouzapw