Skip to content

[URGENT] fix(tests): clear the ESLint base-red on release/v3.8.51 (volcengine any casts) - #13215

Closed
backryun wants to merge 1 commit into
cheaper-inference:release/v3.8.51from
backryun:fix/release-v3.8.51-basereds-eslint
Closed

backryun wants to merge 1 commit into
cheaper-inference:release/v3.8.51from
backryun:fix/release-v3.8.51-basereds-eslint

Conversation

@backryun

Copy link
Copy Markdown
Contributor

Summary

Clears the ESLint base-red on release/v3.8.51 that fans out to every open PR as No new ESLint warnings → red.

tests/unit/volcengine-plan-binding-upsert.test.ts carried three (bindingTesting as any).upsertConnection(...) casts. The __testing.upsertConnection helper is fully typed (exported from src/lib/providers/volcenginePlanBinding.ts), so the casts were dead weight — and with @typescript-eslint/no-explicit-any set to error under tests/, they turned the release tip itself red the moment they merged (originating PR #12950 is already merged, so there is no branch left to fix: this is a base-reds repair PR).

Change

- const updated1 = await (bindingTesting as any).upsertConnection(...)
+ const updated1 = await bindingTesting.upsertConnection(...)

…same for the two other call sites (lines 70/96/120). No production code, no test semantics changed.

Validation (on this branch, from the release tip 8ecdd88c1)

  • npx eslint tests/unit/volcengine-plan-binding-upsert.test.ts --suppressions-location config/quality/eslint-suppressions.json → 0 errors
  • node --import tsx/esm --test tests/unit/volcengine-plan-binding-upsert.test.ts → 3/3 pass

Impact

Notes

@ggiak ggiak left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should fix half the problem, it will bring the release one step closer. We need Fable51 + Astra

…ding suite

The __testing.upsertConnection helper is fully typed, so the casts were dead weight that tripped no-explicit-any on release/v3.8.51 and fanned the ESLint base-red out to every open PR.
@backryun
backryun force-pushed the fix/release-v3.8.51-basereds-eslint branch from 22b117b to 8b6834c Compare September 11, 2026 22:03
@backryun

Copy link
Copy Markdown
Contributor Author

Superseded by #13361, which clears the same release-green hard failures (the volcengine ESLint casts plus the provider-reference counts). Closing so the release branch gets one base-red fix instead of two racing ones.

@backryun backryun closed this Sep 11, 2026
@backryun
backryun deleted the fix/release-v3.8.51-basereds-eslint branch September 11, 2026 22:06
diegosouzapw added a commit that referenced this pull request Sep 17, 2026
…-09-15) (#13731)

Second `npm run release:reconcile` pass on `release/v3.8.50..release/v3.8.51`
(0915890..c0f92ec, 916 non-merge commits, 877 merged PRs):

- fold the 173 changelog.d fragments accumulated since #12971 under
  `## [3.8.51]` and delete them
- generate bullets for the 58 cycle commits that had no fragment
  (4 features / 42 fixes / 12 maintenance), each with the merged PR link and
  `— thanks @author`
- link 137 fragment bullets to the PR of the commit that added them and
  credit the author; two prefix/origin mismatches reviewed (#12945→#13392,
  #13001→#13379, both maintainer rebaselines of other people's PRs)
- refresh "Release by the numbers" + Top-25 and regenerate the
  `### 🙌 Contributors` hall (112 external contributors + maintainer; every
  non-bot author of the 877 merged PRs present)
- closed-PR credit audit for the window: nothing to add (#13215→#13361 and
  #13059→#13690 are still open, #12998 was independently fixed earlier by
  #12853); no human co-author trailers, no commits without a PR
- resync the 58 i18n CHANGELOG mirrors

Gates: check:changelog-integrity OK, check:docs-sync PASS.
muhamadgalihsaputra pushed a commit to niyatna/NiyatnaRoute that referenced this pull request Sep 27, 2026
…-09-15) (cheaper-inference#13731)

Second `npm run release:reconcile` pass on `release/v3.8.50..release/v3.8.51`
(104d4f8..d61b804, 916 non-merge commits, 877 merged PRs):

- fold the 173 changelog.d fragments accumulated since cheaper-inference#12971 under
  `## [3.8.51]` and delete them
- generate bullets for the 58 cycle commits that had no fragment
  (4 features / 42 fixes / 12 maintenance), each with the merged PR link and
  `— thanks @author`
- link 137 fragment bullets to the PR of the commit that added them and
  credit the author; two prefix/origin mismatches reviewed (cheaper-inference#12945→cheaper-inference#13392,
  cheaper-inference#13001→cheaper-inference#13379, both maintainer rebaselines of other people's PRs)
- refresh "Release by the numbers" + Top-25 and regenerate the
  `### 🙌 Contributors` hall (112 external contributors + maintainer; every
  non-bot author of the 877 merged PRs present)
- closed-PR credit audit for the window: nothing to add (cheaper-inference#13215→cheaper-inference#13361 and
  cheaper-inference#13059→cheaper-inference#13690 are still open, cheaper-inference#12998 was independently fixed earlier by
  cheaper-inference#12853); no human co-author trailers, no commits without a PR
- resync the 58 i18n CHANGELOG mirrors

Gates: check:changelog-integrity OK, check:docs-sync PASS.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants