fix: address misc UXR recommdations #1264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kne42 is there a dev link for these? |
Janeece
requested changes
Oct 23, 2024
There was a problem hiding this comment.
Thanks @kne42! seem my comments below.
cc @kandarpksk
#1236 - move annotation filters
- On All Datasets page, the dividing line between annotations and hardware is missing, please add back
- On Single Dataset page, please move annotation filter section above tilt series section
#1237 - clarify code snippet
- Please update so that "code snippet" is lower case instead of capitalized
#1239 - update authors on home page
- looks good, no comments.
#1241 - update download API callout + font size
- copy is in callout seems to be the same as before (i tried clearing cache and hard reload)
|
@Janeece ready for re-review |
codemonkey800
approved these changes
Oct 25, 2024
|
merging because kira is OOO today 🫡 |
github-actions bot
added a commit
that referenced
this pull request
Oct 28, 2024
🤖 I have created a release *beep* *boop* --- ## [1.33.2](web-v1.33.1...web-v1.33.2) (2024-10-28) ### 🐞 Bug Fixes * address misc UXR recommdations ([#1264](#1264)) ([ad55a4c](ad55a4c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1236
fixes #1237
fixes #1239
fixes #1241