Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download modal issues: API callout outdated, consistency of font sizes across tabs #1241

Closed
kandarpksk opened this issue Oct 16, 2024 · 4 comments · Fixed by #1264
Closed
Assignees
Labels
bug Something isn't working severity - medium May interrupt the Portal, causing it to behave in a less than optimal way (e.g., broken link, typo) uxr

Comments

@kandarpksk
Copy link
Collaborator

kandarpksk commented Oct 16, 2024

In the download modal, say when downloading a dataset, there are a couple of issues I noticed in the API tab:
Screenshot

  1. The callout (text with blue background) to be updated to
  1. "Copy Python code snippet" changed to 14 px size using SDS variable "fontheaderS"
@kandarpksk kandarpksk added bug Something isn't working uxr labels Oct 16, 2024
@junxini junxini added the severity - medium May interrupt the Portal, causing it to behave in a less than optimal way (e.g., broken link, typo) label Oct 16, 2024
@Janeece
Copy link
Collaborator

Janeece commented Oct 16, 2024

Recommend matching the callout copy from Download Singel tomogram via API:

Screenshot 2024-10-16 at 11 30 07 AM

@Janeece
Copy link
Collaborator

Janeece commented Oct 16, 2024

@junxini I finished adding info (above), should be ready to be assigned to eng.

@junxini junxini assigned kne42 and unassigned Janeece Oct 17, 2024
@junxini junxini added this to the sprint 7 (phase 4) milestone Oct 17, 2024
@kne42
Copy link
Member

kne42 commented Oct 22, 2024

everything non-style-related here has been addressed by @melissawm in #1256

however, the links differ. do we want to use the one in #1256 (https://chanzuckerberg.github.io/cryoet-data-portal/python-api.html) or in this issue @Janeece?

@Janeece
Copy link
Collaborator

Janeece commented Oct 22, 2024

@kne42 thanks for catching this. Use the one in #1256 (https://chanzuckerberg.github.io/cryoet-data-portal/python-api.html) instead!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working severity - medium May interrupt the Portal, causing it to behave in a less than optimal way (e.g., broken link, typo) uxr
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants