Skip to content

Redirect docs subdomain#739

Merged
jetstack-bot merged 2 commits intocert-manager:masterfrom
chance19:redirect-docs-subdomain
Oct 29, 2021
Merged

Redirect docs subdomain#739
jetstack-bot merged 2 commits intocert-manager:masterfrom
chance19:redirect-docs-subdomain

Conversation

@chance19
Copy link
Contributor

The config in the previous PR did not work, this PR will

Signed-off-by: Chance Whittaker <chance19@gmail.com>
…edirects

Signed-off-by: Chance Whittaker <chance19@gmail.com>
@jetstack-bot jetstack-bot added the dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. label Oct 29, 2021
@netlify
Copy link

netlify bot commented Oct 29, 2021

✔️ Deploy Preview for cert-manager-website ready!

🔨 Explore the source changes: 1d4bea7

🔍 Inspect the deploy log: https://app.netlify.com/sites/cert-manager-website/deploys/617c418237c15b00078dadb8

😎 Browse the preview: https://deploy-preview-739--cert-manager-website.netlify.app

@jetstack-bot jetstack-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 29, 2021
Copy link
Member

@wallrj wallrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 29, 2021
@wallrj wallrj added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 29, 2021
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: chance19, wallrj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot merged commit 202cdf1 into cert-manager:master Oct 29, 2021
@munnerz
Copy link
Member

munnerz commented Oct 30, 2021

Hm I think this has happened after I deleted the old readthedocs site - that site was serving redirects from old config to the new pages.

Given those aren't 1:1 either (some content was re-organised) we may want to consider porting across the old rules... I'll see if I can dig them out!

@munnerz
Copy link
Member

munnerz commented Oct 30, 2021

@munnerz
Copy link
Member

munnerz commented Oct 30, 2021

Which may also want integrating with this: https://github.com/jetstack/cert-manager/blob/release-0.12/docs/redirects for completeness..


# docs.cert-manager.io was previously a separately hosted service. The dns has since been redirect to the main site and the following redirect
# rule will force people with historical links or browser to docs.cert-manager.io to be redirected to the /docs endpoint
https://docs.cert-manager.io/* https://cert-manager.io/docs/ No newline at end of file
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this retain the trailing path segments so they go to the correct page?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It won't - we need to add the :splat to the redirected URL.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue is also that we re-mapped the URLs when moving too I think, see https://github.com/jetstack/cert-manager/blob/release-0.12/docs/redirects

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could set up a small webservice that just serves 301 redirects to fix this up perhaps?

Copy link
Member

@maelvls maelvls Nov 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea.

Should we map all the URLs found on Google? E.g.,

https://docs.cert-manager.io/en/release-0.9/reference/issuers.html maps to https://cert-manager.io/docs/concepts/issuer/?

I did a quick google search, here are the existing links:

https://docs.cert-manager.io/en/release-0.11
https://docs.cert-manager.io/en/release-0.8/
https://docs.cert-manager.io/en/release-0.10/
https://docs.cert-manager.io/en/release-0.9/
https://docs.cert-manager.io/en/release-0.7/
https://docs.cert-manager.io/_/downloads/en/release-0.7/pdf/
https://docs.cert-manager.io/_/downloads/en/release-0.9/pdf/
https://docs.cert-manager.io/en/release-0.9/reference/issuers.html
https://docs.cert-manager.io/en/release-0.11/reference/challenges.html
https://docs.cert-manager.io/_/downloads/en/release-0.10/pdf/
https://docs.cert-manager.io/_/downloads/en/release-0.10/pdf/
https://docs.cert-manager.io/en/release-0.11/reference/certificates.html
https://docs.cert-manager.io/en/release-0.8/reference/orders.html
https://docs.cert-manager.io/en/release-0.11/reference/certificaterequests.html
https://docs.cert-manager.io/en/release-0.9/reference/orders.html
https://docs.cert-manager.io/en/release-0.9/getting-started/webhook.html
https://docs.cert-manager.io/en/release-0.8/reference/clusterissuers.html
https://docs.cert-manager.io/en/release-0.11/reference/clusterissuers.html
https://docs.cert-manager.io/en/release-0.11/getting-started/webhook.html
https://docs.cert-manager.io/en/release-0.7/getting-started/troubleshooting.html
https://docs.cert-manager.io/en/release-0.8/tasks/issuers/index.html
https://docs.cert-manager.io/en/release-0.7/getting-started/install.html
https://docs.cert-manager.io/en/release-0.11/tasks/issuers/index.html
https://docs.cert-manager.io/en/release-0.10/tasks/issuers/index.html
https://docs.cert-manager.io/en/release-0.9/devel/dns01-providers.html
https://docs.cert-manager.io/en/release-0.11/reference/cainjector.html
https://docs.cert-manager.io/en/release-0.11/reference/api-docs/index.html
https://docs.cert-manager.io/en/release-0.9/reference/api-docs/index.html
https://docs.cert-manager.io/en/release-0.9/tasks/issuers/setup-ca.html
https://docs.cert-manager.io/en/release-0.11/tasks/issuers/setup-ca.html
https://docs.cert-manager.io/en/release-0.10/getting-started/install/kubernetes.html
https://docs.cert-manager.io/en/release-0.7/reference/api-docs/index.html
https://docs.cert-manager.io/en/release-0.11/getting-started/install/kubernetes.html
https://docs.cert-manager.io/en/release-0.8/reference/api-docs/index.html
https://docs.cert-manager.io/en/release-0.9/getting-started/index.html
https://docs.cert-manager.io/en/release-0.7/tasks/acme/issuing-certificates.html
https://docs.cert-manager.io/en/release-0.7/tasks/issuing-certificates/index.html
https://docs.cert-manager.io/en/release-0.8/tasks/issuers/setup-ca.html
https://docs.cert-manager.io/en/release-0.8/tasks/issuers/setup-vault.html
https://docs.cert-manager.io/en/release-0.7/tasks/issuers/setup-vault.html
https://docs.cert-manager.io/en/release-0.11/tasks/issuers/setup-vault.html
https://docs.cert-manager.io/en/release-0.10/devel/develop-with-minikube.html
https://docs.cert-manager.io/en/release-0.11/devel/develop-with-minikube.html
https://docs.cert-manager.io/en/release-0.7/tasks/issuers/setup-ca.html
https://docs.cert-manager.io/en/release-0.7/devel/develop-with-minikube.html
https://docs.cert-manager.io/en/release-0.11/tutorials/acme/index.html
https://docs.cert-manager.io/en/release-0.8/devel/develop-with-minikube.html
https://docs.cert-manager.io/en/release-0.7/tasks/acme/configuring-http01.html
https://docs.cert-manager.io/en/release-0.11/tasks/issuers/setup-acme/index.html
https://docs.cert-manager.io/en/release-0.11/tasks/uninstall/index.html
https://docs.cert-manager.io/en/release-0.11/tasks/backup-restore-crds.html
https://docs.cert-manager.io/en/release-0.7/tasks/issuing-certificates/ingress-shim.html
https://docs.cert-manager.io/en/release-0.7/tasks/acme/configuring-dns01/google.html
https://docs.cert-manager.io/en/release-0.7/tasks/issuers/setup-selfsigned.html
https://docs.cert-manager.io/en/release-0.8/tasks/issuing-certificates/ingress-shim.html
https://docs.cert-manager.io/en/release-0.8/tasks/issuers/setup-acme/index.html
https://docs.cert-manager.io/en/release-0.9/tasks/acme/configuring-dns01/google.html
https://docs.cert-manager.io/en/release-0.10/tasks/acme/configuring-dns01/azuredns.html
https://docs.cert-manager.io/en/release-0.10/tasks/issuing-certificates/ingress-shim.html
https://docs.cert-manager.io/en/release-0.8/tasks/issuers/setup-selfsigned.html
https://docs.cert-manager.io/en/release-0.7/tasks/acme/configuring-dns01/azuredns.html
https://docs.cert-manager.io/en/release-0.7/tasks/acme/configuring-dns01/index.html
https://docs.cert-manager.io/en/release-0.7/tasks/acme/configuring-dns01/route53.html
https://docs.cert-manager.io/en/release-0.11/getting-started/install/index.html
https://docs.cert-manager.io/en/release-0.8/tasks/issuers/setup-acme/dns01/google.html
https://docs.cert-manager.io/en/release-0.10/tasks/issuers/setup-acme/dns01/google.html
https://docs.cert-manager.io/en/release-0.9/tasks/acme/configuring-dns01/cloudflare.html
https://docs.cert-manager.io/en/release-0.7/tasks/acme/debugging-failing-orders.html
https://docs.cert-manager.io/en/release-0.9/tasks/acme/configuring-dns01/route53.html
https://docs.cert-manager.io/en/release-0.9/tasks/acme/configuring-dns01/digitalocean.html
https://docs.cert-manager.io/en/release-0.11/tasks/issuers/setup-acme/dns01/azuredns.html
https://docs.cert-manager.io/en/release-0.8/tasks/issuers/setup-acme/dns01/route53.html
https://docs.cert-manager.io/en/release-0.9/tasks/issuers/setup-acme/dns01/akamai.html
🔎 Reproduce
  1. get a key at https://developers.google.com/custom-search/v1/overview
  2. Google a Search Engine ID (cx) at https://programmablesearchengine.google.com/controlpanel/all
  3. Run:
for i in $(seq 0 10 100); do curl -s "https://customsearch.googleapis.com/customsearch/v1?key=$(lpass show -p google-search)&cx=$(lpass show -u google-search)&start=$i&q=site%3Adocs.cert-manager.io" | jq -r '.items[].link'; done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants