Skip to content

Redirect docs subdomain #739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jetstack-bot merged 2 commits into from
Oct 29, 2021
Merged

Redirect docs subdomain #739

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f3ea8a5
removing incorrect redirect config
chance19 Oct 29, 2021
1d4bea7
adding docs redirect config here to remain consistent with existing r…
chance19 Oct 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions _redirects
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,3 +35,7 @@ https://cert-manager.io/docs/usage/kubectl-plugin/#status-certificate https://ce
https://cert-manager.io/docs/usage/kubectl-plugin/#completion https://cert-manager.io/docs/usage/cmctl/#completion
https://cert-manager.io/docs/usage/kubectl-plugin/#experimental https://cert-manager.io/docs/usage/cmctl/#experimental
https://cert-manager.io/docs/usage/kubectl-plugin/#certificatesigningrequest https://cert-manager.io/docs/usage/cmctl/#certificatesigningrequest

# docs.cert-manager.io was previously a separately hosted service. The dns has since been redirect to the main site and the following redirect
# rule will force people with historical links or browser to docs.cert-manager.io to be redirected to the /docs endpoint
https://docs.cert-manager.io/* https://cert-manager.io/docs/
Copy link
Member

@munnerz munnerz Oct 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this retain the trailing path segments so they go to the correct page?

Copy link
Contributor

@mattbates mattbates Nov 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It won't - we need to add the :splat to the redirected URL.

Copy link
Member

@munnerz munnerz Nov 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue is also that we re-mapped the URLs when moving too I think, see https://github.com/jetstack/cert-manager/blob/release-0.12/docs/redirects

Copy link
Member

@munnerz munnerz Nov 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could set up a small webservice that just serves 301 redirects to fix this up perhaps?

Copy link
Member

@maelvls maelvls Nov 2, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea.

Should we map all the URLs found on Google? E.g.,

https://docs.cert-manager.io/en/release-0.9/reference/issuers.html maps to https://cert-manager.io/docs/concepts/issuer/?

I did a quick google search, here are the existing links:

https://docs.cert-manager.io/en/release-0.11
https://docs.cert-manager.io/en/release-0.8/
https://docs.cert-manager.io/en/release-0.10/
https://docs.cert-manager.io/en/release-0.9/
https://docs.cert-manager.io/en/release-0.7/
https://docs.cert-manager.io/_/downloads/en/release-0.7/pdf/
https://docs.cert-manager.io/_/downloads/en/release-0.9/pdf/
https://docs.cert-manager.io/en/release-0.9/reference/issuers.html
https://docs.cert-manager.io/en/release-0.11/reference/challenges.html
https://docs.cert-manager.io/_/downloads/en/release-0.10/pdf/
https://docs.cert-manager.io/_/downloads/en/release-0.10/pdf/
https://docs.cert-manager.io/en/release-0.11/reference/certificates.html
https://docs.cert-manager.io/en/release-0.8/reference/orders.html
https://docs.cert-manager.io/en/release-0.11/reference/certificaterequests.html
https://docs.cert-manager.io/en/release-0.9/reference/orders.html
https://docs.cert-manager.io/en/release-0.9/getting-started/webhook.html
https://docs.cert-manager.io/en/release-0.8/reference/clusterissuers.html
https://docs.cert-manager.io/en/release-0.11/reference/clusterissuers.html
https://docs.cert-manager.io/en/release-0.11/getting-started/webhook.html
https://docs.cert-manager.io/en/release-0.7/getting-started/troubleshooting.html
https://docs.cert-manager.io/en/release-0.8/tasks/issuers/index.html
https://docs.cert-manager.io/en/release-0.7/getting-started/install.html
https://docs.cert-manager.io/en/release-0.11/tasks/issuers/index.html
https://docs.cert-manager.io/en/release-0.10/tasks/issuers/index.html
https://docs.cert-manager.io/en/release-0.9/devel/dns01-providers.html
https://docs.cert-manager.io/en/release-0.11/reference/cainjector.html
https://docs.cert-manager.io/en/release-0.11/reference/api-docs/index.html
https://docs.cert-manager.io/en/release-0.9/reference/api-docs/index.html
https://docs.cert-manager.io/en/release-0.9/tasks/issuers/setup-ca.html
https://docs.cert-manager.io/en/release-0.11/tasks/issuers/setup-ca.html
https://docs.cert-manager.io/en/release-0.10/getting-started/install/kubernetes.html
https://docs.cert-manager.io/en/release-0.7/reference/api-docs/index.html
https://docs.cert-manager.io/en/release-0.11/getting-started/install/kubernetes.html
https://docs.cert-manager.io/en/release-0.8/reference/api-docs/index.html
https://docs.cert-manager.io/en/release-0.9/getting-started/index.html
https://docs.cert-manager.io/en/release-0.7/tasks/acme/issuing-certificates.html
https://docs.cert-manager.io/en/release-0.7/tasks/issuing-certificates/index.html
https://docs.cert-manager.io/en/release-0.8/tasks/issuers/setup-ca.html
https://docs.cert-manager.io/en/release-0.8/tasks/issuers/setup-vault.html
https://docs.cert-manager.io/en/release-0.7/tasks/issuers/setup-vault.html
https://docs.cert-manager.io/en/release-0.11/tasks/issuers/setup-vault.html
https://docs.cert-manager.io/en/release-0.10/devel/develop-with-minikube.html
https://docs.cert-manager.io/en/release-0.11/devel/develop-with-minikube.html
https://docs.cert-manager.io/en/release-0.7/tasks/issuers/setup-ca.html
https://docs.cert-manager.io/en/release-0.7/devel/develop-with-minikube.html
https://docs.cert-manager.io/en/release-0.11/tutorials/acme/index.html
https://docs.cert-manager.io/en/release-0.8/devel/develop-with-minikube.html
https://docs.cert-manager.io/en/release-0.7/tasks/acme/configuring-http01.html
https://docs.cert-manager.io/en/release-0.11/tasks/issuers/setup-acme/index.html
https://docs.cert-manager.io/en/release-0.11/tasks/uninstall/index.html
https://docs.cert-manager.io/en/release-0.11/tasks/backup-restore-crds.html
https://docs.cert-manager.io/en/release-0.7/tasks/issuing-certificates/ingress-shim.html
https://docs.cert-manager.io/en/release-0.7/tasks/acme/configuring-dns01/google.html
https://docs.cert-manager.io/en/release-0.7/tasks/issuers/setup-selfsigned.html
https://docs.cert-manager.io/en/release-0.8/tasks/issuing-certificates/ingress-shim.html
https://docs.cert-manager.io/en/release-0.8/tasks/issuers/setup-acme/index.html
https://docs.cert-manager.io/en/release-0.9/tasks/acme/configuring-dns01/google.html
https://docs.cert-manager.io/en/release-0.10/tasks/acme/configuring-dns01/azuredns.html
https://docs.cert-manager.io/en/release-0.10/tasks/issuing-certificates/ingress-shim.html
https://docs.cert-manager.io/en/release-0.8/tasks/issuers/setup-selfsigned.html
https://docs.cert-manager.io/en/release-0.7/tasks/acme/configuring-dns01/azuredns.html
https://docs.cert-manager.io/en/release-0.7/tasks/acme/configuring-dns01/index.html
https://docs.cert-manager.io/en/release-0.7/tasks/acme/configuring-dns01/route53.html
https://docs.cert-manager.io/en/release-0.11/getting-started/install/index.html
https://docs.cert-manager.io/en/release-0.8/tasks/issuers/setup-acme/dns01/google.html
https://docs.cert-manager.io/en/release-0.10/tasks/issuers/setup-acme/dns01/google.html
https://docs.cert-manager.io/en/release-0.9/tasks/acme/configuring-dns01/cloudflare.html
https://docs.cert-manager.io/en/release-0.7/tasks/acme/debugging-failing-orders.html
https://docs.cert-manager.io/en/release-0.9/tasks/acme/configuring-dns01/route53.html
https://docs.cert-manager.io/en/release-0.9/tasks/acme/configuring-dns01/digitalocean.html
https://docs.cert-manager.io/en/release-0.11/tasks/issuers/setup-acme/dns01/azuredns.html
https://docs.cert-manager.io/en/release-0.8/tasks/issuers/setup-acme/dns01/route53.html
https://docs.cert-manager.io/en/release-0.9/tasks/issuers/setup-acme/dns01/akamai.html
🔎 Reproduce
  1. get a key at https://developers.google.com/custom-search/v1/overview
  2. Google a Search Engine ID (cx) at https://programmablesearchengine.google.com/controlpanel/all
  3. Run:
for i in $(seq 0 10 100); do curl -s "https://customsearch.googleapis.com/customsearch/v1?key=$(lpass show -p google-search)&cx=$(lpass show -u google-search)&start=$i&q=site%3Adocs.cert-manager.io" | jq -r '.items[].link'; done

6 changes: 0 additions & 6 deletions config/_default/config.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,9 +95,3 @@ googleAnalytics = "UA-78700849-2"
[algolia]
index = "cert-manager-latest"
appID = "18N9PEKHUC"

[[redirects]]
from = "https://docs.cert-manager.io"
to = "https://cert-manager.io/docs/"
status = 301
force = true