Skip to content

added multiple azure managed identities documentation#688

Merged
jetstack-bot merged 5 commits intocert-manager:release-nextfrom
tomasfreund:multiple-azure-managed-identities
Sep 3, 2021
Merged

added multiple azure managed identities documentation#688
jetstack-bot merged 5 commits intocert-manager:release-nextfrom
tomasfreund:multiple-azure-managed-identities

Conversation

@tomasfreund
Copy link

@tomasfreund tomasfreund commented Aug 16, 2021

Signed-off-by: Tomáš Freund tomas.freund@datamole.cz

Documentation for pull request cert-manager/cert-manager#4332

@jetstack-bot jetstack-bot added the dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. label Aug 16, 2021
@netlify
Copy link

netlify bot commented Aug 16, 2021 •
edited
Loading

✔️ Deploy Preview for cert-manager-website ready!

🔨 Explore the source changes: ee75bf5

🔍 Inspect the deploy log: https://app.netlify.com/sites/cert-manager-website/deploys/61323bfccd27360008b57c45

😎 Browse the preview: https://deploy-preview-688--cert-manager-website.netlify.app/docs/configuration/acme/dns01/azuredns

@jetstack-bot jetstack-bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 16, 2021
@jetstack-bot
Copy link
Contributor

jetstack-bot commented Aug 16, 2021

Hi @tomasfreund. Thanks for your PR.

I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jetstack-bot jetstack-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 16, 2021
@tomasfreund tomasfreund mentioned this pull request Aug 16, 2021
Merged
@tomasfreund
Copy link
Author

tomasfreund commented Aug 20, 2021

/assign @wallrj

@jakexks
Copy link
Member

jakexks commented Aug 25, 2021

/ok-to-test

@jetstack-bot jetstack-bot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 25, 2021
jakexks
jakexks requested changes Aug 25, 2021
View reviewed changes
Copy link
Member

@jakexks jakexks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tomasfreund

If this is documentation for a feature that will be in 1.6, please could you make this PR against the release-next branch? Anything merged into master is live on the website, which could be confusing for users seeing documentation for a feature that does not yet exist.

jakexks
jakexks reviewed Aug 25, 2021
View reviewed changes
@tomasfreund tomasfreund changed the base branch from master to release-next August 25, 2021 14:29
@jetstack-bot jetstack-bot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 25, 2021
@tomasfreund
add multiple azure managed identities docs
b4cf820 
Signed-off-by: Tomáš Freund <tomas.freund@datamole.cz>
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. and removed dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. labels Aug 25, 2021
@tomasfreund
remove word as per code review suggestion
990386c 
Signed-off-by: Tomáš Freund <tomas.freund@datamole.cz>
@tomasfreund
remove word as per code review suggestion
6893e8c 
Signed-off-by: Tomáš Freund <tomas.freund@datamole.cz>
@tomasfreund tomasfreund requested a review from jakexks August 25, 2021 14:49
@tomasfreund
Copy link
Author

tomasfreund commented Aug 31, 2021

Hi, is there anything more I need to do to get this and cert-manager/cert-manager#4332 merged?

@wallrj
Quote the words clientID and resourceID to satisfy the spell checker
73036b0 
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
@wallrj
Whitespace cleanup
ee75bf5 
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
@jetstack-bot jetstack-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 3, 2021
wallrj
wallrj reviewed Sep 3, 2021
View reviewed changes
Copy link
Member

@wallrj wallrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tomasfreund

I quoted a couple of words to satisfy the spell-checker and cleaned up some trailing whitespace.

Thanks again for all your work on this.

/lgtm
/approve

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 3, 2021
@wallrj wallrj added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Sep 3, 2021
@jetstack-bot
Copy link
Contributor

jetstack-bot commented Sep 3, 2021

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: tomasfreund, wallrj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot merged commit 8ad939b into cert-manager:release-next Sep 3, 2021
@jetstack-bot jetstack-bot mentioned this pull request Oct 19, 2021
Merged
@jetstack-bot jetstack-bot mentioned this pull request Oct 27, 2021
Merged
@jetstack-bot jetstack-bot mentioned this pull request Jan 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wallrj wallrj wallrj left review comments

@jakexks jakexks Awaiting requested review from jakexks

Assignees

@wallrj wallrj

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. ok-to-test size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tomasfreund @jetstack-bot @jakexks @wallrj