Adds documentation for CSR supporting all issuers, and the CTL command#615
Merged
jetstack-bot merged 6 commits intocert-manager:release-nextfrom Jul 27, 2021
Merged
Conversation
jetstack-bot
added
do-not-merge/cherry-pick-not-approved
This was referenced Jun 18, 2021
JoshVanL
force-pushed
the
csr-all-issuers
branch
from
3882a46 to
5fc3392
Compare
jetstack-bot
added
dco-signoff: no
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
JoshVanL
force-pushed
the
csr-all-issuers
branch
from
5fc3392 to
e30e686
Compare
jetstack-bot
added
dco-signoff: yes
|
✔️ Deploy Preview for cert-manager-website ready! 🔨 Explore the source changes: 42b5064 🔍 Inspect the deploy log: https://app.netlify.com/sites/cert-manager-website/deploys/60ffcfbedf4a610008601cd4 😎 Browse the preview: https://deploy-preview-615--cert-manager-website.netlify.app |
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
Contributor
Author
|
/retest |
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
irbekrm
approved these changes
Jul 26, 2021
Contributor
irbekrm
left a comment
irbekrm
left a comment
There was a problem hiding this comment.
Looks good and clear to me.
Adding an lgtm with a hold if you want to address the two optional nits I added
/lgtm
/hold
jetstack-bot
added
the
do-not-merge/hold
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: irbekrm, JoshVanL The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
/cherry-pick-approve |
irbekrm
added
the
cherry-pick-approved
jetstack-bot
removed
do-not-merge/cherry-pick-not-approved
Contributor
Author
|
Thanks @irbekrm, can you take another look? |
`kubectl cert-manager x` description Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
Contributor
|
Thanks for adding the changes, I've read through the doc again and it looks good /lgtm |
Contributor
|
/hold cancel |
jetstack-bot
removed
the
do-not-merge/hold
This was referenced Aug 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: joshvanl vleeuwenjoshua@gmail.com
This PR documents the support for all CSR signer types, including their used annotations.
Also documents the
cert-manager x create csrcommand.This PR has been updated to remove the
experimental.cert-manager.io/caannotation, which has been removed from cert-manager.