Certificate signing request ca issuer#587
Merged
jetstack-bot merged 5 commits intocert-manager:release-nextfrom Jun 14, 2021
Merged
Certificate signing request ca issuer#587jetstack-bot merged 5 commits intocert-manager:release-nextfrom
jetstack-bot merged 5 commits intocert-manager:release-nextfrom
Conversation
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
jetstack-bot
added
do-not-merge/cherry-pick-not-approved
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoshVanL The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jetstack-bot
added
size/L
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
13 tasks
Member
|
From this morning's discussion: we want to update the website's FAQ to mention that the CSRs are now partially supported in cert-manager. |
maelvls
reviewed
Jun 8, 2021
content/en/docs/usage/kube-csr.md
Outdated
| > Note: cert-manager currently only supports signing CertificateSigningRequests | ||
| > using the [CA issuer](../../configuration/ca/). | ||
|
|
||
| > Note: cert-manager _will not_ automatically approve CertificateSigningRequests |
Member
There was a problem hiding this comment.
nit: use present tense instead of future
Suggested change
| > Note: cert-manager _will not_ automatically approve CertificateSigningRequests | |
| > Note: cert-manager does not automatically approve CertificateSigningRequests |
maelvls
requested changes
Jun 8, 2021
Member
maelvls
left a comment
maelvls
left a comment
There was a problem hiding this comment.
Looks neat. Would it be possible to add a note in the FAQ?
Contributor
Author
|
@maelvls Please take another look |
JoshVanL
force-pushed
the
certificate-signing-request-ca-issuer
branch
from
7560bc2 to
519b80c
Compare
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
Member
|
Looks nice and clear, thank you! /lgtm |
Member
|
/label cherry-pick-approved |
maelvls
added
the
cherry-pick-approved
jetstack-bot
removed
the
do-not-merge/cherry-pick-not-approved
This was referenced Jun 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.