Add EXTRACTSegmentation class for PyNWB
#4
Conversation
| function. | ||
| required: false | ||
| - name: pre_mask_on | ||
| dtype: bool |
There was a problem hiding this comment.
In MATLAB this say's it is encoded as a double (float64), but I doubt it would ever be a value other than 0 or 1, so fine to keep as bool. Just leaving this as a note
| dtype: int32 | ||
| doc: int32ean flag that determines whether to subtract the (spatial) background | ||
| (largest spatiotemporal mode of the movie matrix). | ||
| dtype: bool |
There was a problem hiding this comment.
Similar to above, this is encoded in MATLAB as double, but usage seems to be binary so fine to keep as bool here.
|
The schema data type changes LGTM - from the MATLAB view, all such values are either 'logical' (MATLAB native 'bool') or 'double' (float64, or just 'float' in Python). I'm inclined to trust all the autogenerated extension stuff, but maybe @rly would know more about all that. |
|
Leaving here as a mental note that to read the NWB files produced with this update using To install !git clone --branch 466-support-bools https://github.com/NeurodataWithoutBorders/matnwb.git
cd matnwb/
generateCore(); |
|
LGTM! Thanks for all the work on this |
|
Will approve and merge once NeurodataWithoutBorders/matnwb#467 is merged in MatNWB |
Update extension for storing the available configuration parameters from the EXTRACT algorithm.
The update concerns the
PyNWBside where an EXTRACTSegmentation class is defined with all the configuration parameters that can be extracted from the EXTRACT output file.The extensions yaml file is updated:
float32tofloat64uint8toboolwhere the description of the configuration setting indicates the usage of a boolean data type.All configuration values are optional.