Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In extensions.yaml, docstrings say "int32ean" in multiple places #3

Closed
rly opened this issue Sep 12, 2022 · 2 comments
Closed

In extensions.yaml, docstrings say "int32ean" in multiple places #3

rly opened this issue Sep 12, 2022 · 2 comments

Comments

@rly
Copy link

rly commented Sep 12, 2022

"int32ean" -> "boolean" ?
This seems like a find-and-replace accident.

    doc: int32ean flag indicating data preprocessing before main EXTRACT function
@rly
Copy link
Author

rly commented Sep 12, 2022

Related: are these attributes supposed to be boolean?

@weiglszonja
Copy link
Contributor

@rly I opened #4 where I'm changing these attributes to boolean.
Reading these in h5py they show up as uint8, but similarly to that example, the attribute preprocess of 1 would indicate to run preprocessing, so ultimately I felt they should be written as True/False values. @bendichter explained to me the complexity of writing values as boolean, so I'm okay with keeping them how we read them in h5py. How do you feel about this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rly @weiglszonja @CodyCBakerPhD