-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support boolean values #467
Conversation
Now returns table objects which match the default io.parseCompound function.
reorder long lines, remove useless comments.
Codecov Report
@@ Coverage Diff @@
## master #467 +/- ##
==========================================
+ Coverage 87.53% 87.56% +0.02%
==========================================
Files 127 128 +1
Lines 5247 5348 +101
==========================================
+ Hits 4593 4683 +90
- Misses 654 665 +11
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@lawrence-mbf this looks good to me! Do you know what lines of code are untested and how they might be tested? I can see that you added a test that does I/O for bool, but I'm not crazy about lowering our test coverage numbers if we can avoid it |
@bendichter I'll take a look at it. I think some of it is because of certain branches in |
The branch is still there so for coverage it's probably best to test it. We need to cheat a little with this change as it is now guaranteed that reading compound data types returns tables instead of structs with vectors.
Error message moved into addRow function.
@bendichter coverage improved |
Heya, this is needed for catalystneuro/ndx-extract#4 and other things around the ecosystem, I'm sure. Anything left to do here? |
@CodyCBakerPhD Just eyes. All behavior tests are passing. |
When used with catalystneuro/ndx-extract#4 creates values appearing like in HDFView, and when using @bendichter Any last thoughts? |
Motivation
h5py boolean values were not supported correctly.
How to test the behavior?
See #466 (comment)
This PR only fixes a subset of issues when reading this file.
Checklist
fix #XX
whereXX
is the issue number?