fix(Tag): update filter tags to match updated spec #7664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emyarod
force-pushed
the
7630-filter-tag-spec
branch
from
22ffbed
to
7b2a6cf
Compare
|
Deploy preview for carbon-elements ready! Built with commit 22ffbed |
|
Deploy preview for carbon-components-react ready! Built with commit 22ffbed https://deploy-preview-7664--carbon-components-react.netlify.app |
|
Deploy preview for carbon-elements ready! Built with commit d14a965 |
|
Deploy preview for carbon-components-react ready! Built with commit d14a965 https://deploy-preview-7664--carbon-components-react.netlify.app |
emyarod
force-pushed
the
7630-filter-tag-spec
branch
from
399c6ad
to
f6d3dca
Compare
laurenmrice
approved these changes
Jan 27, 2021
tw15egan
reviewed
Jan 27, 2021
tw15egan
reviewed
Jan 27, 2021
emyarod
force-pushed
the
7630-filter-tag-spec
branch
from
f6d3dca
to
d14a965
Compare
dakahn
approved these changes
Jan 28, 2021
andreancardona
added
status: ready to merge 🎉
and removed
status: one more review 👀
status: ready for review 👀
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7630
related #7619
This PR updates the filter tag and the new small filter tags to match the updated component spec. Unblocks #7518
Testing / Reviewing
Ensure the filter tag variants match the component spec