feat(Tag): implement short tag size #7619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for carbon-elements ready! Built with commit 7b790b2 |
joshblack
approved these changes
Jan 21, 2021
|
Deploy preview for carbon-components-react ready! Built with commit 18bf8e1 https://deploy-preview-7619--carbon-components-react.netlify.app |
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit 7b790b2 https://deploy-preview-7619--carbon-components-react.netlify.app |
|
Should we reduce the size of the icon in the custom icon variant when the size is small as well? |
laurenmrice
requested changes
Jan 22, 2021
There was a problem hiding this comment.
- The text in the filterable tag is getting cut off at the bottom for both sizes.
- Can we name the 18px tag
smallinstead of short? - I don't think we need to change the size of the custom icon when using the small tag. 16px is our smallest icon size and it is also going to be the size of the close icon for the filterable tag still.
emyarod
force-pushed
the
7512-short-tag
branch
from
9435574
to
afae172
Compare
laurenmrice
approved these changes
Jan 25, 2021
tw15egan
approved these changes
Jan 25, 2021
tw15egan
requested changes
Jan 25, 2021
emyarod
force-pushed
the
7512-short-tag
branch
from
5efd446
to
b8d7fb4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7512
related #4953
This PR implements support for short Tag and Filter Tag sizes
Changelog
New
sizesupport for short tagsTesting / Reviewing
Confirm the short tag, short filter tag, and short skeleton tags appear correct