Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tag] fix hover and focus for filterable tag #7630

Closed
laurenmrice opened this issue Jan 22, 2021 · 2 comments · Fixed by #7664
Closed

[tag] fix hover and focus for filterable tag #7630

laurenmrice opened this issue Jan 22, 2021 · 2 comments · Fixed by #7664
Assignees
@emyarod
Labels
component: tags role: dev 🤖 type: bug 🐛

Comments

@laurenmrice
Copy link
Member

  • The current hover and focus states are slightly off for our filterable tag component.
  • Since we are also adding a small tag variation, we need to make an adjustment to these states so they are consistent across both sizes.

Artboard Copy 4

Artboard Copy 5
@emyarod
Copy link
Member

emyarod commented Jan 22, 2021

also impacts #7518

@emyarod
Copy link
Member

emyarod commented Jan 25, 2021

small tag will be addressed by #7619, so we can just track the default tag updates here!

@emyarod emyarod mentioned this issue Jan 27, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emyarod emyarod

Labels
component: tags role: dev 🤖 type: bug 🐛
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(Tag): update filter tags to match updated spec emyarod/carbon
2 participants
@emyarod @laurenmrice