-
Notifications
You must be signed in to change notification settings - Fork 874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ubuntu/devel #4801
Merged
Merged
Ubuntu/devel #4801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on (canonical#4683) Use leases directory and lease file provided by Distro object instead of cycling through all possible locations.
Release 4.21.0 broke tests
PR canonical#4683 changes missed Alpine. This PR addresses this.
) Integration tests allow for installing a new version of cloud-init with the option of snapshotting the image after install. After taking a snapshot, it will then set the snapshot as the default for *all* future launches in this test run. This is also used by the conftest to setup the initial image, but it should not be used anywhere else. Rather than having it as an option to the install_new_cloud_init method, remove the option and make the confest set the global snapshot instead. This removes a footgun when writing other tests that need to install a different version of cloud-init.
`get_top_level_dir` and `cloud_init_project_dir` have uses in integration tests. Move them up to a top-level test helper file accordingly.
This feature adds support for log rotation (logrotate.d) for cloud-init logs located in /var/log. Fixes canonicalGH-4509
Add schema validation for physical nic name length of 15. Add integration tests to assert this schema validation behavior. Fixes: canonicalGH-4743
When the clean command is run, runparts is called and README in /etc/cloud/clean.d is not executable which leads to a warning. No longer deliver the README in our deb package, move content to our online docs. Continue to deliver the /etc/cloud/clean.d directory as it is used by installers like subiquity. Fixes: canonicalGH-4760
Add delaycompression flag, allow for 6 backups and use log globbing to match any future cloud-init*.log files
Commit 0e247c8 introduced logrotate functionality, but integration tests won't pass because packaged config is delivered at /etc/logrotate.d/cloud-init. Update logrotate file path.
Add the missing Scaleway datasource documentation to the list of datasources of the reference section.
…it.d script (canonical#4785) Add OpenRC init.d script for ds-identify. Add support to ds-identify for "virt-what" as an alternative to "systemd-detect-virt" for non-systemd Linux distros. Change ds-identify to use short option for "modprobe" for Busybox compatibility. Change ds-identify to use short options for "grep" as POSIX does not define long options, they are a GNU-ism.
With the recent changes in failure reporting and diagnostics, the full log is unnecessary overhead. Rename push_log_to_kvp() => report_dmesg_to_kvp() now that it only captures the dmesg log. Raise call to report_dmesg_to_kvp to _report_success/failure(). Signed-off-by: Chris Patterson <[email protected]>
Netplan tests are failing on KeyError: 'match' for expected; this change initializes the key.
Commit ce07818 introduced new doc links for Scaleway datasource. Ignore anchors which sphinx linkcheck cannot parse. Fixes CI linkcheck failures.
Supplemental integration test missed in commit 7206652. This will all be reverted with Noble cloud-image builds with /etc/cloud/build.info serial that is greater than 20240110.
…anonical#4327)" This reverts commit 816e05d. Reopens LP: 2030729 Fixes canonicalGH-4794
Bump the version in cloudinit/version.py to 23.4.2 and update ChangeLog.
blackboxsw
approved these changes
Jan 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changeset good, build and lint good. Confirming jenkins integration test results that had some spurious errors prior to merging and uploading to noble.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
do not squash
New downstream devel release including the fix for https://bugs.launchpad.net/ubuntu/+source/cloud-init/+bug/2051147