tests: add exit 2 on noble from cloud-init status #4792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Supplemental integration test missed in commit 7206652. This will all be reverted with Noble cloud-image builds with /etc/cloud/build.info serial that is greater than 20240110.
|
cc: @catmsred for triage. |
catmsred
approved these changes
Jan 23, 2024
TheRealFalcon
approved these changes
Jan 23, 2024
| # Expect warning exit code 2 on Ubuntu Noble due to cloud-init | ||
| # disabling /etc/apt/sources.list build artifact in favor of deb822 | ||
| result = class_client.execute("cloud-init status --wait --long") | ||
| return_code = 2 if CURRENT_RELEASE.series == "noble" else 0 |
There was a problem hiding this comment.
Nit: in the future we should use something like
return_code = 2 if CURRENT_RELEASE >= NOBLE else 0but since this will all be reverted, it looks good as is
catmsred
added a commit
to catmsred/cloud-init
that referenced
this pull request
Jan 25, 2024
New noble download images are building again so they should not return 2 on cloud-init status --wait. This change reverts the temporary fix to allow our tests to pass during the out of sync period.
catmsred
added a commit
to catmsred/cloud-init
that referenced
this pull request
Jan 25, 2024
New noble download images are building again so they should not return 2 on cloud-init status --wait. This change reverts the temporary fix to allow our tests to pass during the out of sync period.
TheRealFalcon
pushed a commit
that referenced
this pull request
Jan 25, 2024
New noble download images are building again so they should not return 2 on cloud-init status --wait. This change reverts the temporary fix to allow our tests to pass during the out of sync period.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rebase merge
Proposed Commit Message
Additional Context
One other integration test missed expecting exit 2 on noble due to deb822 duplicated source warnings.
Both this PR and 7206652 will likely need to be revoked within a week when cloudimage builds are unblocked for noble.
Test Steps
Checklist
Merge type