Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify ds-identify for Alpine support and add OpenRC init.d script #4785

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

dermotbradley
Copy link
Contributor

feat(Alpine): Modify ds-identify for Alpine support and add OpenRC init.d script

Add OpenRC init.d script for ds-identify.

Add support to ds-identify for "virt-what" as an alternative to
"systemd-detect-virt" for non-systemd Linux distros.

Change ds-identify to use short option for "modprobe" for Busybox
compatibility.

Change ds-identify to use short options for "grep" as POSIX does not
define long options, they are a GNU-ism.

Additional Context

Test Steps

Checklist

Merge type

  • Squash merge using "Proposed Commit Message"
  • Rebase and merge unique commits. Requires commit messages per-commit each referencing the pull request number (#<PR_NUM>)

Add OpenRC init.d script for ds-identify.

Add support to ds-identify for "virt-what" as an alternative to
"systemd-detect-virt" for non-systemd Linux distros.

Change ds-identify to use short option for "modprobe" for Busybox
compatibility.

Change ds-identify to use short options for "grep" as POSIX does not
define long options, they are a GNU-ism.
Copy link
Collaborator

@igalic igalic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks pretty good at first blush

@holmanb holmanb self-assigned this Jan 18, 2024
@dermotbradley
Copy link
Contributor Author

The use of "virt-what" is a bit of a stop-gap, I'm considering writing an alternative (also in Shell) that uses /sys/class/dmi rather than "dmidecode" and that handles containers also (which virt-what doesn't).

Copy link
Member

@holmanb holmanb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thanks @dermotbradley!

@holmanb holmanb merged commit ae38d4b into canonical:main Jan 22, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants