Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make text non selectable if inside a button [web] #2283

Closed

Conversation

RichardLindhout
Copy link
Contributor

@RichardLindhout RichardLindhout commented Oct 10, 2020

Summary

Provide same behaviour across platforms since text is non-selectable by default on other platforms.
Fixes: #2258
94059145-50e76680-fde2-11ea-82d9-8c01f65f6415

Test plan

@RichardLindhout RichardLindhout changed the title fix: make text non selectable if inside a button fix: make text non selectable if inside a button [web] Oct 10, 2020
@callstack-bot
Copy link

callstack-bot commented Oct 10, 2020

Hey @RichardLindhout, thank you for your pull request 🤗. The documentation from this branch can be viewed here.

@Trancever Trancever requested a review from satya164 October 20, 2020 08:41
@Trancever
Copy link
Contributor

Trancever commented Oct 27, 2020

@RichardLindhout Thanks for the contribution! Could you resolve the conflicts and make sure lint and tests are passing? Once it's done we would like to merge the PR.

@RichardLindhout
Copy link
Contributor Author

Yes, will try to look at it this week a little bit short on time a.t.m.

@RichardLindhout
Copy link
Contributor Author

@Trancever done

@RichardLindhout
Copy link
Contributor Author

RichardLindhout commented Oct 30, 2020

@Trancever We still need it inside the react-native-vector package but I don't think the maintainer will add my PR (oblador/react-native-vector-icons#1252) anytime soon based on all the PR's which are open.

I'll add it here for now!

flow-typed/npm/babel-preset-react-native_vx.x.x.js Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@Trancever
Copy link
Contributor

@RichardLindhout What's the status of it? Let me know if you don't have time to work on this one so someone from the core team will finish it. Cheers!

@RichardLindhout
Copy link
Contributor Author

RichardLindhout commented Nov 18, 2020

Thanks for the feedback! It would be nice if the core-team could cherry-picking the commits since I had a hard time to fix this the last time since I don't get how that works

@RichardLindhout
Copy link
Contributor Author

Hey @Trancever I have fixed some new conflicts, could we maybe merge this soon?

@Trancever
Copy link
Contributor

@RichardLindhout I cherry-picked only the relevant commit and it's already on a master!

@Trancever Trancever closed this Dec 8, 2020
RichardLindhout added a commit to RichardLindhout/react-native-paper that referenced this pull request Dec 29, 2020
Trancever pushed a commit that referenced this pull request Jan 5, 2021
james-watkin added a commit to james-watkin/react-native-paper that referenced this pull request Dec 28, 2021
crazymobdev added a commit to crazymobdev/react_native_paper that referenced this pull request Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Text is selectable on the web inside buttons
4 participants