-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make text non selectable if inside a button [web] #2283
fix: make text non selectable if inside a button [web] #2283
Conversation
Hey @RichardLindhout, thank you for your pull request 🤗. The documentation from this branch can be viewed here. |
@RichardLindhout Thanks for the contribution! Could you resolve the conflicts and make sure lint and tests are passing? Once it's done we would like to merge the PR. |
Yes, will try to look at it this week a little bit short on time a.t.m. |
@Trancever done |
@Trancever We still need it inside the react-native-vector package but I don't think the maintainer will add my PR (oblador/react-native-vector-icons#1252) anytime soon based on all the PR's which are open. I'll add it here for now! |
@RichardLindhout What's the status of it? Let me know if you don't have time to work on this one so someone from the core team will finish it. Cheers! |
Thanks for the feedback! It would be nice if the core-team could cherry-picking the commits since I had a hard time to fix this the last time since I don't get how that works |
Hey @Trancever I have fixed some new conflicts, could we maybe merge this soon? |
@RichardLindhout I cherry-picked only the relevant commit and it's already on a master! |
Small part of callstack#2283 did not get merged.
Small part of #2283 did not get merged.
Small part of callstack/react-native-paper#2283 did not get merged.
Small part of callstack/react-native-paper#2283 did not get merged.
Summary
Provide same behaviour across platforms since text is non-selectable by default on other platforms.
Fixes: #2258
Test plan