Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text is selectable on the web inside buttons #2258

Closed
RichardLindhout opened this issue Sep 23, 2020 · 5 comments
Closed

Text is selectable on the web inside buttons #2258

RichardLindhout opened this issue Sep 23, 2020 · 5 comments
Labels

Comments

@RichardLindhout
Copy link
Contributor

RichardLindhout commented Sep 23, 2020

I would like to make the text/icons non-selectable by default which is the case on iOS and Android but not on the web where the text is selectable by default. This will be the cause in the future too as I discussed with the maintainer of react-native-web, because text selecting is important on the web.

That's right, you can disable text selection as needed. I think React Native gets text selection wrong by default and produces inaccessible experiences, especially on web.

necolas/react-native-web#1741

Current behaviour

ezgif-7-623a8fe9c78c

Expected behaviour

That the text is non-selectable like on Android and iOS.

What have you tried

oblador/react-native-vector-icons#1252 > PR for icons non-selectable by default on the web

web-ridge/react-native-paper-dates#19. I can send PR's but I think I better wait till the PR's from @unikvozm are merged?

@github-actions
Copy link

Couldn't find version numbers for the following packages in the issue:

  • react-native
  • react-native-paper
  • react-native-vector-icons

Can you update the issue to include version numbers for those packages? The version numbers must match the format 1.2.3.

@RichardLindhout
Copy link
Contributor Author

@unikvozm do you know when your PR's will get merged? Or should I make PR's to existing components

@unikvozm
Copy link
Contributor

@unikvozm do you know when your PR's will get merged? Or should I make PR's to existing components

Merging my PRs is still in progress... I think you can create your branch from my branch and in your PR mention that “should be merged after ...”

@github-actions
Copy link

Hello 👋, this issue has been open for more than 2 months with no activity on it. If the issue is still present in the latest version, please leave a comment within 7 days to keep it open, otherwise it will be closed automatically. If you found a solution on workaround for the issue, please comment here for others to find. If this issue is critical for you, please consider sending a pull request to fix the issue.

@github-actions github-actions bot added the Stale label Dec 10, 2020
@RichardLindhout
Copy link
Contributor Author

Looks like this is almost fixed, I think not all the changes from the PR are merged since the Icon inside a button is still selectable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants