Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make icons on web non-selectable like on other platforms #19

Closed
RichardLindhout opened this issue Sep 23, 2020 · 5 comments
Closed

Make icons on web non-selectable like on other platforms #19

RichardLindhout opened this issue Sep 23, 2020 · 5 comments
Assignees
@RichardLindhout
Labels
Blocked by React Native Paper bug Something isn't working

Comments

@RichardLindhout
Copy link
Member

As Necolas from react-native-web pointed out here it's expected that text is selectable on the web by default.
necolas/react-native-web#1741

We should make a PR to react-native-vector-icons to disable text selecting for their Icon elements to improve the web experience as icons don't really have a use case for selecting.

We should make a PR to react-native-paper to disable selecting their Text element which are in buttons.

Illustration of current behaviour
ezgif-7-623a8fe9c78c
@RichardLindhout
Copy link
Member Author

PR for react-native-vector-icons is up: oblador/react-native-vector-icons#1252

@RichardLindhout RichardLindhout mentioned this issue Sep 23, 2020
Merged
@RichardLindhout RichardLindhout changed the title Make buttons on web work like expected Make buttons and icons on web work like expected Sep 23, 2020
@RichardLindhout RichardLindhout changed the title Make buttons and icons on web work like expected Make buttons and icons on web non-selectable like on other platforms Sep 23, 2020
@RichardLindhout RichardLindhout mentioned this issue Sep 23, 2020
Closed
@RichardLindhout
Copy link
Member Author

Issue for React Native Paper is up: callstack/react-native-paper#2258

@RichardLindhout
Copy link
Member Author

PR is approved now waiting for ti to get merged in react-native-paper. React-native-vector icons PR is not needed as we handled it in the PR for react-native-paper too!

@RichardLindhout RichardLindhout self-assigned this Nov 21, 2020
@RichardLindhout
Copy link
Member Author

callstack/react-native-paper#2283

@RichardLindhout RichardLindhout changed the title Make buttons and icons on web non-selectable like on other platforms Make icons on web non-selectable like on other platforms Dec 24, 2020
@RichardLindhout
Copy link
Member Author

RichardLindhout commented Jan 20, 2021 •
edited
Loading

Yeah this can be closed now. Is released in [email protected]. Big <3 to @Trancever for getting this through

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RichardLindhout RichardLindhout

Labels
Blocked by React Native Paper bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@RichardLindhout