Conversation
I'm just learning so a bit unsure, but I believe scrutineer (with the "r") may have been the word the author was going for, but in this context "alternative" probably makes more sense? ...
Co-authored-by: Claudio Russo <claudio@dfinity.org>
|
This PR does not affect the produced WebAssembly code. |
osa1
approved these changes
Jun 21, 2021
Contributor
osa1
left a comment
osa1
left a comment
There was a problem hiding this comment.
LGTM.
Some of the changes are just rewording, for example:
- We see that an object with three fields is being built
+ This code constructs a record with three fieldsI'm curious how to evaluate such changes?
Contributor
Author
No idea, I'm using the force. |
This was referenced Jun 21, 2021
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #2616
PR #2615
PR #2613
PR #2611
PR #2609
PR #2608
PR #2607
CI isn't working properly for forks, so merging these external PRs by hand.