reworded. by cPlayIt · Pull Request #2612 · caffeinelabs/motoko

cPlayIt · 2021-06-19T20:24:49Z

No description provided.

dfinity-ci · 2021-06-19T20:31:49Z

This PR does not affect the produced WebAssembly code.

alternative makes most sense to me as an extension of scrutineer. You have 2 scrutineers, 2 alternatives... ... but with just 1 option, it should probably be scrutineer as there's only one case block doing the scrutinizing if I am following.

doc/modules/language-guide/pages/pattern-matching.adoc

Co-authored-by: Claudio Russo <claudio@dfinity.org>

doc/modules/language-guide/pages/pattern-matching.adoc

crusso · 2021-06-21T12:44:26Z

doc/modules/language-guide/pages/pattern-matching.adoc

+When a pattern check alternative has the potential to fail, then it becomes important to find out whether the whole `switch` expression can fail. If this can happen the execution of the program can trap for certain inputs, posing an operational threat. To this end, the compiler checks for the exhaustiveness of pattern matching by keeping track of the covered shape of the scrutinee. The compiler issues a warning for any non-covered scrutinees ({proglang} even constructs a helpful example of a scrutinee that is not matched). As by-product of the exhaustiveness check, warnings are also issued for dead alternatives.

-In summary, pattern checking is a great tool for several use-cases and enables active assistance from the compiler to the programmer by pointing out which inputs are not exhaustively taken care of. The static compile-time nature of coverage checking reliably rules out runtime failures.
+In summary, pattern checking is a great tool with several use-cases. By statically analyzing patterns, the compiler can assists the programmer by pointing out unhandled cases and unreachable code, both of which often indicate programmer error. The static compile-time nature of coverage checking reliably rules out runtime failures.


Suggested change

In summary, pattern checking is a great tool with several use-cases. By statically analyzing patterns, the compiler can assists the programmer by pointing out unhandled cases and unreachable code, both of which often indicate programmer error. The static compile-time nature of coverage checking reliably rules out runtime failures.

In summary, pattern checking is a great tool with several use-cases. By statically analyzing patterns, the compiler can assists the programmer by pointing out unhandled cases and unreachable code, both of which often indicate programmer error. The static, compile-time nature of coverage checking reliably rules out runtime failures.

doc/modules/language-guide/pages/pattern-matching.adoc

crusso · 2021-06-21T13:54:21Z

Incorporated into #2619

reworded.

c66df6b

reworded

4255462

alternative makes most sense to me as an extension of scrutineer. You have 2 scrutineers, 2 alternatives... ... but with just 1 option, it should probably be scrutineer as there's only one case block doing the scrutinizing if I am following.

crusso reviewed Jun 20, 2021

View reviewed changes