Skip to content

Comments

possible error#2613

Closed
cPlayIt wants to merge 3 commits intocaffeinelabs:masterfrom
cPlayIt:patch-18
Closed

possible error#2613
cPlayIt wants to merge 3 commits intocaffeinelabs:masterfrom
cPlayIt:patch-18

Conversation

@cPlayIt
Copy link
Contributor

@cPlayIt cPlayIt commented Jun 19, 2021

I'm just learning so a bit unsure, but I believe scrutineer (with the "r") may have been the word the author was going for, but in this context "alternative" probably makes more sense? ...

I'm just learning so a bit unsure, but I believe scrutineer (with the "r") may have been the word the author was going for, but in this context "alternative" probably makes more sense? ...
@dfinity-ci
Copy link

This PR does not affect the produced WebAssembly code.

@ggreif
Copy link
Contributor

ggreif commented Jun 19, 2021

There are no such things as dead scrutinees in a call-by-value language. You are correct that alternative is the right word. It is also defined a few lines up.

@cPlayIt
Copy link
Contributor Author

cPlayIt commented Jun 19, 2021 via email

@ggreif ggreif added automerge-squash When ready, merge (using squash) and removed automerge-squash When ready, merge (using squash) labels Jun 19, 2021
crusso added a commit that referenced this pull request Jun 21, 2021
PR #2616
PR #2615
PR #2613
PR #2611
PR #2609
PR #2608
PR #2607

CI isn't working properly for forks, so merging these external PRs by hand.
@crusso
Copy link
Contributor

crusso commented Jun 21, 2021

Incorporated into #2619

@crusso crusso closed this Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants