Conversation
rossberg
reviewed
Feb 6, 2019
Contributor
rossberg
left a comment
rossberg
left a comment
There was a problem hiding this comment.
Thanks, this looks good. However, for coherence it would be good to also remove class functions (represented as the Construct func_sort internally) at the same time.
Contributor
Author
|
You don’t need them during type-checking to know what names introduce type synonyms? Ok, will remove it then. |
functions are either Local or Sharable, but we no longer have to distinguish Construct.
Contributor
Author
|
I made this independent of the (dubious) #148, and rebased this branch onto master. |
nomeata
force-pushed
the
joachim/no-class-type
branch
from
4899a81 to
4ca8a22
Compare
rossberg
approved these changes
Feb 6, 2019
Contributor
rossberg
left a comment
rossberg
left a comment
There was a problem hiding this comment.
Thanks!. Looks good modulo comments.
dfinity-bot
added a commit
that referenced
this pull request
Dec 9, 2020
## Changelog for candid: Branch: master Commits: [dfinity/candid@b25d7361...41589d66](dfinity/candid@b25d736...41589d6) * [`a49897b0`](dfinity/candid@a49897b) [Rust] allow using keyword as field label ([dfinity/candid#149](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity/candid/issues/149)) * [`41589d66`](dfinity/candid@41589d6) release ([dfinity/candid#150](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity/candid/issues/150))
mergify bot
pushed a commit
that referenced
this pull request
Dec 9, 2020
## Changelog for candid: Branch: master Commits: [dfinity/candid@b25d7361...41589d66](dfinity/candid@b25d736...41589d6) * [`a49897b0`](dfinity/candid@a49897b) [Rust] allow using keyword as field label ([dfinity/candid#149](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity/candid/issues/149)) * [`41589d66`](dfinity/candid@41589d6) release ([dfinity/candid#150](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity/candid/issues/150))
dfinity-bot
added a commit
that referenced
this pull request
Mar 1, 2023
## Changelog for ic-hs: Branch: master Commits: [dfinity/ic-hs@927d8152...808ba08b](dfinity/ic-hs@927d815...808ba08) * [`54dcdd0c`](dfinity/ic-hs@54dcdd0) .github/workflows/release.yml: only sync github pages on linux ([dfinity/ic-hs#143](https://github.com/dfinity/ic-hs/issues/143)) * [`81ac2e9c`](dfinity/ic-hs@81ac2e9) .github/workflows/release.yml: fix github-pages-deploy-action version ([dfinity/ic-hs#144](https://github.com/dfinity/ic-hs/issues/144)) * [`09a7b445`](dfinity/ic-hs@09a7b44) fix broken link in README ([dfinity/ic-hs#145](https://github.com/dfinity/ic-hs/issues/145)) * [`b393d8cb`](dfinity/ic-hs@b393d8c) .github/workflows/release.yml: skip coverage job on darwin ([dfinity/ic-hs#146](https://github.com/dfinity/ic-hs/issues/146)) * [`55870466`](dfinity/ic-hs@5587046) split haskell modules to reduce memory usage ([dfinity/ic-hs#142](https://github.com/dfinity/ic-hs/issues/142)) * [`6ddff2e4`](dfinity/ic-hs@6ddff2e) add httpbin implementation in Rust, bump nixpkgs, and sync universal_canister with ic monorepo ([dfinity/ic-hs#138](https://github.com/dfinity/ic-hs/issues/138)) * [`808ba08b`](dfinity/ic-hs@808ba08) split Multiple controllers tests ([dfinity/ic-hs#149](https://github.com/dfinity/ic-hs/issues/149))
dfinity-bot
added a commit
that referenced
this pull request
Mar 2, 2023
## Changelog for ic-hs: Branch: master Commits: [dfinity/ic-hs@927d8152...bdaaa321](dfinity/ic-hs@927d815...bdaaa32) * [`54dcdd0c`](dfinity/ic-hs@54dcdd0) .github/workflows/release.yml: only sync github pages on linux ([dfinity/ic-hs#143](https://github.com/dfinity/ic-hs/issues/143)) * [`81ac2e9c`](dfinity/ic-hs@81ac2e9) .github/workflows/release.yml: fix github-pages-deploy-action version ([dfinity/ic-hs#144](https://github.com/dfinity/ic-hs/issues/144)) * [`09a7b445`](dfinity/ic-hs@09a7b44) fix broken link in README ([dfinity/ic-hs#145](https://github.com/dfinity/ic-hs/issues/145)) * [`b393d8cb`](dfinity/ic-hs@b393d8c) .github/workflows/release.yml: skip coverage job on darwin ([dfinity/ic-hs#146](https://github.com/dfinity/ic-hs/issues/146)) * [`55870466`](dfinity/ic-hs@5587046) split haskell modules to reduce memory usage ([dfinity/ic-hs#142](https://github.com/dfinity/ic-hs/issues/142)) * [`6ddff2e4`](dfinity/ic-hs@6ddff2e) add httpbin implementation in Rust, bump nixpkgs, and sync universal_canister with ic monorepo ([dfinity/ic-hs#138](https://github.com/dfinity/ic-hs/issues/138)) * [`808ba08b`](dfinity/ic-hs@808ba08) split Multiple controllers tests ([dfinity/ic-hs#149](https://github.com/dfinity/ic-hs/issues/149)) * [`bdaaa321`](dfinity/ic-hs@bdaaa32) bump cachix/install-nix-action to v20 ([dfinity/ic-hs#150](https://github.com/dfinity/ic-hs/issues/150))
mergify bot
pushed a commit
that referenced
this pull request
Mar 2, 2023
## Changelog for ic-hs: Branch: master Commits: [dfinity/ic-hs@927d8152...bdaaa321](dfinity/ic-hs@927d815...bdaaa32) * [`54dcdd0c`](dfinity/ic-hs@54dcdd0) .github/workflows/release.yml: only sync github pages on linux ([dfinity/ic-hs#143](https://github.com/dfinity/ic-hs/issues/143)) * [`81ac2e9c`](dfinity/ic-hs@81ac2e9) .github/workflows/release.yml: fix github-pages-deploy-action version ([dfinity/ic-hs#144](https://github.com/dfinity/ic-hs/issues/144)) * [`09a7b445`](dfinity/ic-hs@09a7b44) fix broken link in README ([dfinity/ic-hs#145](https://github.com/dfinity/ic-hs/issues/145)) * [`b393d8cb`](dfinity/ic-hs@b393d8c) .github/workflows/release.yml: skip coverage job on darwin ([dfinity/ic-hs#146](https://github.com/dfinity/ic-hs/issues/146)) * [`55870466`](dfinity/ic-hs@5587046) split haskell modules to reduce memory usage ([dfinity/ic-hs#142](https://github.com/dfinity/ic-hs/issues/142)) * [`6ddff2e4`](dfinity/ic-hs@6ddff2e) add httpbin implementation in Rust, bump nixpkgs, and sync universal_canister with ic monorepo ([dfinity/ic-hs#138](https://github.com/dfinity/ic-hs/issues/138)) * [`808ba08b`](dfinity/ic-hs@808ba08) split Multiple controllers tests ([dfinity/ic-hs#149](https://github.com/dfinity/ic-hs/issues/149)) * [`bdaaa321`](dfinity/ic-hs@bdaaa32) bump cachix/install-nix-action to v20 ([dfinity/ic-hs#150](https://github.com/dfinity/ic-hs/issues/150))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the only useful operation on it was
is, but that has been removed(#145). So no need to have a
Classtype around any more.This is part of the clean-up following #81.
(NB: This builds on top of PR #148.)