Skip to content

Async ir#138

Merged
crusso merged 32 commits intomasterfrom
async-ir
Feb 5, 2019
Merged

Async ir#138
crusso merged 32 commits intomasterfrom
async-ir

Conversation

@crusso
Copy link
Contributor

@crusso crusso commented Feb 4, 2019 •
edited
Loading

Carry on from Matthew's port of tailcall.ml to tailcall_ir and port await.ml and async.ml to await_ir.ml and async_ir.ml. Originals retained for use by interpreter (for now).
Parameterize checker by additional, phase-specific check_exp and check_typ functions.
Move bespoke checking of output into each transform to simplify pipeline.
Clean up desugar.ml and make it self-checking.

matthewhammer and others added 23 commits January 30, 2019 16:00
@matthewhammer
starting on IR-based refactoring of existing syntaxops module
48ce023
@matthewhammer
starting on IR-based refactoring of existing syntaxops module
aa4e910
@matthewhammer
broken state: marked all places that need edits
4936642
@matthewhammer
still broken, but fewer broken parts, hopefully
503efae
@matthewhammer
fixed remaining questions with Claudio's help
4b25aee
@matthewhammer
minor; avoid warning
061d24b
@matthewhammer
revert change to .gitignore
0b6a586
@matthewhammer
Revert "minor; avoid warning"
7d7ed49 
This reverts commit 061d24b.
@matthewhammer
Merge branch 'master' of github.com:dfinity-lab/actorscript into synt…
d924f11 
…axops-ir
@matthewhammer
fix 'unused module' warning
d567333
@matthewhammer
refactor tailcall module to use Ir in place of Syntax
40a5606
@matthewhammer
minor: fix confusing typo in note
7aa8825
@matthewhammer
use Claudio's review: hints and feedback
26072a4
@matthewhammer
use Claudio's review: hints and feedback, continued.
c7bf4e4
@crusso
enable and fix tailcall_ir
517dd14
@crusso
initial port to async_ir.ml
81f2e5f
@crusso
ported async.ml to async_ir.ml
453d58f 
add .mli files
fixed bug in check_ir.ml
formatting
updated test output
@crusso
port rename.ml to rename_ir.ml
98a30b0
@crusso
awaitopt_ir.ml
61b49a8
@crusso
ported awaitopt.ir to awaitopt_ir.ml, and removed impossible cases; f…
f5698c1 
…ormatting
@crusso
tidy
6cf7744
@crusso
push (bespoke) validation into transforms
0f71eba
@crusso
refactoring
b03291a
@crusso crusso requested a review from nomeata February 4, 2019 18:59
@crusso crusso requested a review from matthewhammer February 4, 2019 19:00
@crusso crusso requested a review from rossberg February 5, 2019 07:23
@nomeata
Copy link
Contributor

nomeata commented Feb 5, 2019

Originals retained for use by interpreter (for now).

Once we have an IR version of the interpreter (which I’d be inclined to tackle next) we can remove the copies, right?

nomeata
nomeata reviewed Feb 5, 2019
View reviewed changes
@nomeata nomeata mentioned this pull request Feb 5, 2019
Closed
nomeata
nomeata reviewed Feb 5, 2019
View reviewed changes
nomeata
nomeata approved these changes Feb 5, 2019
View reviewed changes
Copy link
Contributor

@nomeata nomeata left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. With the legacy modules gone, I’d prefer the non _ir names. But otherwise, LGTM.

Ignore that, I misread the diff.

@crusso crusso merged commit 40d0cac into master Feb 5, 2019
@crusso crusso deleted the async-ir branch February 5, 2019 16:56
@nomeata
Copy link
Contributor

nomeata commented Feb 5, 2019

Yay :-)

dfinity-bot added a commit that referenced this pull request Feb 28, 2020
@dfinity-bot
## Changelog for common:
b0f3809 
Commits: [dfinity-lab/common@7278afe2...6f8f0311](https://github.com/dfinity-lab/common/compare/7278afe2b6ddcd0c78c82fae38160bc4583fc1a6...6f8f03113b16177e35c9ac7ea3448e3a4aa2d055)

* [422f8ec5](https://github.com/dfinity-lab/common/commit/422f8ec5d23e0ceae4db28ede0f1be578a87ea65) unpacker: stop trampling (#138)
* [3f4d3077](https://github.com/dfinity-lab/common/commit/3f4d307796b48c535f7cd2c2eb6c9298c5387928) nix: specify a sha256 for fetching sources.nix
* [4d317b75](https://github.com/dfinity-lab/common/commit/4d317b75180773cdd70a5189e7ffab295c96edd8) Merge pull request #139 from dfinity-lab/basvandijk/specify-sha256-for-sources.nix
* [6f8f0311](https://github.com/dfinity-lab/common/commit/6f8f03113b16177e35c9ac7ea3448e3a4aa2d055) INF-1023: Run benchmarks on CI
@dfinity-bot dfinity-bot mentioned this pull request Feb 28, 2020
Merged
mergify bot pushed a commit that referenced this pull request Feb 28, 2020
@dfinity-bot
## Changelog for common: (#1250)
e93a3dd 
Commits: [dfinity-lab/common@7278afe2...6f8f0311](https://github.com/dfinity-lab/common/compare/7278afe2b6ddcd0c78c82fae38160bc4583fc1a6...6f8f03113b16177e35c9ac7ea3448e3a4aa2d055)

* [422f8ec5](https://github.com/dfinity-lab/common/commit/422f8ec5d23e0ceae4db28ede0f1be578a87ea65) unpacker: stop trampling (#138)
* [3f4d3077](https://github.com/dfinity-lab/common/commit/3f4d307796b48c535f7cd2c2eb6c9298c5387928) nix: specify a sha256 for fetching sources.nix
* [4d317b75](https://github.com/dfinity-lab/common/commit/4d317b75180773cdd70a5189e7ffab295c96edd8) Merge pull request #139 from dfinity-lab/basvandijk/specify-sha256-for-sources.nix
* [6f8f0311](https://github.com/dfinity-lab/common/commit/6f8f03113b16177e35c9ac7ea3448e3a4aa2d055) INF-1023: Run benchmarks on CI
dfinity-bot added a commit that referenced this pull request Aug 1, 2020
@dfinity-bot
niv motoko-base: update 0375b45d -> c27c5255
983f6f8 
## Changelog for motoko-base:
Branch: next-moc
Commits: [caffeinelabs/motoko-base@0375b45d...c27c5255](caffeinelabs/motoko-base@0375b45...c27c525)

* [`ffd149cc`](caffeinelabs/motoko-base@ffd149c) bumps dfx version
* [`8d673459`](caffeinelabs/motoko-base@8d67345) Add TrieSet functions to convert to/from arrays ([dfinity-lab/motoko-base⁠#150](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/motoko-base/issues/150))
* [`9bcc23fb`](caffeinelabs/motoko-base@9bcc23f) Documentation for Array module ([dfinity-lab/motoko-base⁠#138](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/motoko-base/issues/138))
* [`239385d0`](caffeinelabs/motoko-base@239385d) Document Deque module ([dfinity-lab/motoko-base⁠#132](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/motoko-base/issues/132))
* [`381e73a2`](caffeinelabs/motoko-base@381e73a) Adds a script to visualize module dependencies ([dfinity-lab/motoko-base⁠#153](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/motoko-base/issues/153))
* [`3cb61d18`](caffeinelabs/motoko-base@3cb61d1) Fixes module documentation headers ([dfinity-lab/motoko-base⁠#154](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/motoko-base/issues/154))
* [`75b2fb55`](caffeinelabs/motoko-base@75b2fb5) Fix Set.fromArray ([dfinity-lab/motoko-base⁠#155](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/motoko-base/issues/155))
mergify bot pushed a commit that referenced this pull request Aug 1, 2020
@dfinity-bot
niv motoko-base: update 0375b45d -> c27c5255 (#1789)
4c1ab69 
## Changelog for motoko-base:
Branch: next-moc
Commits: [caffeinelabs/motoko-base@0375b45d...c27c5255](caffeinelabs/motoko-base@0375b45...c27c525)

* [`ffd149cc`](caffeinelabs/motoko-base@ffd149c) bumps dfx version
* [`8d673459`](caffeinelabs/motoko-base@8d67345) Add TrieSet functions to convert to/from arrays ([dfinity-lab/motoko-base⁠#150](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/motoko-base/issues/150))
* [`9bcc23fb`](caffeinelabs/motoko-base@9bcc23f) Documentation for Array module ([dfinity-lab/motoko-base⁠#138](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/motoko-base/issues/138))
* [`239385d0`](caffeinelabs/motoko-base@239385d) Document Deque module ([dfinity-lab/motoko-base⁠#132](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/motoko-base/issues/132))
* [`381e73a2`](caffeinelabs/motoko-base@381e73a) Adds a script to visualize module dependencies ([dfinity-lab/motoko-base⁠#153](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/motoko-base/issues/153))
* [`3cb61d18`](caffeinelabs/motoko-base@3cb61d1) Fixes module documentation headers ([dfinity-lab/motoko-base⁠#154](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/motoko-base/issues/154))
* [`75b2fb55`](caffeinelabs/motoko-base@75b2fb5) Fix Set.fromArray ([dfinity-lab/motoko-base⁠#155](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/motoko-base/issues/155))
dfinity-bot added a commit that referenced this pull request Nov 20, 2020
@dfinity-bot
niv candid: update 30f719fa -> 47366bab
e601b04 
## Changelog for candid:
Branch: 
Commits: [dfinity/candid@30f719fa...47366bab](dfinity/candid@30f719f...47366ba)

* [`47366bab`](dfinity/candid@47366ba) Use Deserialisation consistently, not Deserialization ([dfinity/candid⁠#138](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity/candid/issues/138))
mergify bot pushed a commit that referenced this pull request Nov 20, 2020
@dfinity-bot
niv candid: update 30f719fa -> 47366bab (#2136)
a5c285e 
## Changelog for candid:
Branch: 
Commits: [dfinity/candid@30f719fa...47366bab](dfinity/candid@30f719f...47366ba)

* [`47366bab`](dfinity/candid@47366ba) Use Deserialisation consistently, not Deserialization ([dfinity/candid⁠#138](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity/candid/issues/138))
dfinity-bot added a commit that referenced this pull request Feb 28, 2023
@dfinity-bot
niv ic-hs: update 927d8152 -> 6ddff2e4
5cbe8a6 
## Changelog for ic-hs:
Branch: master
Commits: [dfinity/ic-hs@927d8152...6ddff2e4](dfinity/ic-hs@927d815...6ddff2e)

* [`54dcdd0c`](dfinity/ic-hs@54dcdd0) .github/workflows/release.yml: only sync github pages on linux ([dfinity/ic-hs⁠#143](https://github.com/dfinity/ic-hs/issues/143))
* [`81ac2e9c`](dfinity/ic-hs@81ac2e9) .github/workflows/release.yml: fix github-pages-deploy-action version ([dfinity/ic-hs⁠#144](https://github.com/dfinity/ic-hs/issues/144))
* [`09a7b445`](dfinity/ic-hs@09a7b44) fix broken link in README ([dfinity/ic-hs⁠#145](https://github.com/dfinity/ic-hs/issues/145))
* [`b393d8cb`](dfinity/ic-hs@b393d8c) .github/workflows/release.yml: skip coverage job on darwin ([dfinity/ic-hs⁠#146](https://github.com/dfinity/ic-hs/issues/146))
* [`55870466`](dfinity/ic-hs@5587046) split haskell modules to reduce memory usage ([dfinity/ic-hs⁠#142](https://github.com/dfinity/ic-hs/issues/142))
* [`6ddff2e4`](dfinity/ic-hs@6ddff2e) add httpbin implementation in Rust, bump nixpkgs, and sync universal_canister with ic monorepo ([dfinity/ic-hs⁠#138](https://github.com/dfinity/ic-hs/issues/138))
dfinity-bot added a commit that referenced this pull request Mar 1, 2023
@dfinity-bot
niv ic-hs: update 927d8152 -> 808ba08b
ad2ec82 
## Changelog for ic-hs:
Branch: master
Commits: [dfinity/ic-hs@927d8152...808ba08b](dfinity/ic-hs@927d815...808ba08)

* [`54dcdd0c`](dfinity/ic-hs@54dcdd0) .github/workflows/release.yml: only sync github pages on linux ([dfinity/ic-hs⁠#143](https://github.com/dfinity/ic-hs/issues/143))
* [`81ac2e9c`](dfinity/ic-hs@81ac2e9) .github/workflows/release.yml: fix github-pages-deploy-action version ([dfinity/ic-hs⁠#144](https://github.com/dfinity/ic-hs/issues/144))
* [`09a7b445`](dfinity/ic-hs@09a7b44) fix broken link in README ([dfinity/ic-hs⁠#145](https://github.com/dfinity/ic-hs/issues/145))
* [`b393d8cb`](dfinity/ic-hs@b393d8c) .github/workflows/release.yml: skip coverage job on darwin ([dfinity/ic-hs⁠#146](https://github.com/dfinity/ic-hs/issues/146))
* [`55870466`](dfinity/ic-hs@5587046) split haskell modules to reduce memory usage ([dfinity/ic-hs⁠#142](https://github.com/dfinity/ic-hs/issues/142))
* [`6ddff2e4`](dfinity/ic-hs@6ddff2e) add httpbin implementation in Rust, bump nixpkgs, and sync universal_canister with ic monorepo ([dfinity/ic-hs⁠#138](https://github.com/dfinity/ic-hs/issues/138))
* [`808ba08b`](dfinity/ic-hs@808ba08) split Multiple controllers tests ([dfinity/ic-hs⁠#149](https://github.com/dfinity/ic-hs/issues/149))
dfinity-bot added a commit that referenced this pull request Mar 2, 2023
@dfinity-bot
niv ic-hs: update 927d8152 -> bdaaa321
e156e32 
## Changelog for ic-hs:
Branch: master
Commits: [dfinity/ic-hs@927d8152...bdaaa321](dfinity/ic-hs@927d815...bdaaa32)

* [`54dcdd0c`](dfinity/ic-hs@54dcdd0) .github/workflows/release.yml: only sync github pages on linux ([dfinity/ic-hs⁠#143](https://github.com/dfinity/ic-hs/issues/143))
* [`81ac2e9c`](dfinity/ic-hs@81ac2e9) .github/workflows/release.yml: fix github-pages-deploy-action version ([dfinity/ic-hs⁠#144](https://github.com/dfinity/ic-hs/issues/144))
* [`09a7b445`](dfinity/ic-hs@09a7b44) fix broken link in README ([dfinity/ic-hs⁠#145](https://github.com/dfinity/ic-hs/issues/145))
* [`b393d8cb`](dfinity/ic-hs@b393d8c) .github/workflows/release.yml: skip coverage job on darwin ([dfinity/ic-hs⁠#146](https://github.com/dfinity/ic-hs/issues/146))
* [`55870466`](dfinity/ic-hs@5587046) split haskell modules to reduce memory usage ([dfinity/ic-hs⁠#142](https://github.com/dfinity/ic-hs/issues/142))
* [`6ddff2e4`](dfinity/ic-hs@6ddff2e) add httpbin implementation in Rust, bump nixpkgs, and sync universal_canister with ic monorepo ([dfinity/ic-hs⁠#138](https://github.com/dfinity/ic-hs/issues/138))
* [`808ba08b`](dfinity/ic-hs@808ba08) split Multiple controllers tests ([dfinity/ic-hs⁠#149](https://github.com/dfinity/ic-hs/issues/149))
* [`bdaaa321`](dfinity/ic-hs@bdaaa32) bump cachix/install-nix-action to v20 ([dfinity/ic-hs⁠#150](https://github.com/dfinity/ic-hs/issues/150))
mergify bot pushed a commit that referenced this pull request Mar 2, 2023
@dfinity-bot
niv ic-hs: update 927d8152 -> bdaaa321 (#3847)
e9cb4a8 
## Changelog for ic-hs:
Branch: master
Commits: [dfinity/ic-hs@927d8152...bdaaa321](dfinity/ic-hs@927d815...bdaaa32)

* [`54dcdd0c`](dfinity/ic-hs@54dcdd0) .github/workflows/release.yml: only sync github pages on linux ([dfinity/ic-hs⁠#143](https://github.com/dfinity/ic-hs/issues/143))
* [`81ac2e9c`](dfinity/ic-hs@81ac2e9) .github/workflows/release.yml: fix github-pages-deploy-action version ([dfinity/ic-hs⁠#144](https://github.com/dfinity/ic-hs/issues/144))
* [`09a7b445`](dfinity/ic-hs@09a7b44) fix broken link in README ([dfinity/ic-hs⁠#145](https://github.com/dfinity/ic-hs/issues/145))
* [`b393d8cb`](dfinity/ic-hs@b393d8c) .github/workflows/release.yml: skip coverage job on darwin ([dfinity/ic-hs⁠#146](https://github.com/dfinity/ic-hs/issues/146))
* [`55870466`](dfinity/ic-hs@5587046) split haskell modules to reduce memory usage ([dfinity/ic-hs⁠#142](https://github.com/dfinity/ic-hs/issues/142))
* [`6ddff2e4`](dfinity/ic-hs@6ddff2e) add httpbin implementation in Rust, bump nixpkgs, and sync universal_canister with ic monorepo ([dfinity/ic-hs⁠#138](https://github.com/dfinity/ic-hs/issues/138))
* [`808ba08b`](dfinity/ic-hs@808ba08) split Multiple controllers tests ([dfinity/ic-hs⁠#149](https://github.com/dfinity/ic-hs/issues/149))
* [`bdaaa321`](dfinity/ic-hs@bdaaa32) bump cachix/install-nix-action to v20 ([dfinity/ic-hs⁠#150](https://github.com/dfinity/ic-hs/issues/150))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matthewhammer matthewhammer Awaiting requested review from matthewhammer

@rossberg rossberg Awaiting requested review from rossberg

1 more reviewer

@nomeata nomeata nomeata approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@matthewhammer matthewhammer

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@crusso @nomeata @matthewhammer