Merged
Conversation
this fixes #81. It removes `IsE` from both ASTs, the parser, and related code. It might be possible to simplify the type checker or the type system further, with this gone, but I’ll leave that to Andreas.
it is unsed (according to the types), and I *believe* it is no longer useful with `instance-of` gone. But I am not sure. I hope I am helping Andreas here… :-)
rossberg
approved these changes
Feb 5, 2019
nomeata
added a commit
that referenced
this pull request
Feb 6, 2019
previously, objects might have had a class identity that is not valid across different actors, so we distinguished between shared and non-shared objects. With `is` removed (#145), we no longer that distinction; an object is a subtype of `Shared` if and only if all fields are (same as for tuples, as one would expect). This removes a bunch of code. It might be that Andreas could have implemented this faster on his own than reviewing this PR, but I wanted to sieze the opportunity to learn more about the type chekcker etc. It is one of the clean-ups menionted in #81 (there are more left though). It fixes #103.
Merged
dfinity-bot
added a commit
that referenced
this pull request
Feb 28, 2023
## Changelog for ic-hs: Branch: master Commits: [dfinity/ic-hs@927d8152...6ddff2e4](dfinity/ic-hs@927d815...6ddff2e) * [`54dcdd0c`](dfinity/ic-hs@54dcdd0) .github/workflows/release.yml: only sync github pages on linux ([dfinity/ic-hs#143](https://github.com/dfinity/ic-hs/issues/143)) * [`81ac2e9c`](dfinity/ic-hs@81ac2e9) .github/workflows/release.yml: fix github-pages-deploy-action version ([dfinity/ic-hs#144](https://github.com/dfinity/ic-hs/issues/144)) * [`09a7b445`](dfinity/ic-hs@09a7b44) fix broken link in README ([dfinity/ic-hs#145](https://github.com/dfinity/ic-hs/issues/145)) * [`b393d8cb`](dfinity/ic-hs@b393d8c) .github/workflows/release.yml: skip coverage job on darwin ([dfinity/ic-hs#146](https://github.com/dfinity/ic-hs/issues/146)) * [`55870466`](dfinity/ic-hs@5587046) split haskell modules to reduce memory usage ([dfinity/ic-hs#142](https://github.com/dfinity/ic-hs/issues/142)) * [`6ddff2e4`](dfinity/ic-hs@6ddff2e) add httpbin implementation in Rust, bump nixpkgs, and sync universal_canister with ic monorepo ([dfinity/ic-hs#138](https://github.com/dfinity/ic-hs/issues/138))
dfinity-bot
added a commit
that referenced
this pull request
Mar 1, 2023
## Changelog for ic-hs: Branch: master Commits: [dfinity/ic-hs@927d8152...808ba08b](dfinity/ic-hs@927d815...808ba08) * [`54dcdd0c`](dfinity/ic-hs@54dcdd0) .github/workflows/release.yml: only sync github pages on linux ([dfinity/ic-hs#143](https://github.com/dfinity/ic-hs/issues/143)) * [`81ac2e9c`](dfinity/ic-hs@81ac2e9) .github/workflows/release.yml: fix github-pages-deploy-action version ([dfinity/ic-hs#144](https://github.com/dfinity/ic-hs/issues/144)) * [`09a7b445`](dfinity/ic-hs@09a7b44) fix broken link in README ([dfinity/ic-hs#145](https://github.com/dfinity/ic-hs/issues/145)) * [`b393d8cb`](dfinity/ic-hs@b393d8c) .github/workflows/release.yml: skip coverage job on darwin ([dfinity/ic-hs#146](https://github.com/dfinity/ic-hs/issues/146)) * [`55870466`](dfinity/ic-hs@5587046) split haskell modules to reduce memory usage ([dfinity/ic-hs#142](https://github.com/dfinity/ic-hs/issues/142)) * [`6ddff2e4`](dfinity/ic-hs@6ddff2e) add httpbin implementation in Rust, bump nixpkgs, and sync universal_canister with ic monorepo ([dfinity/ic-hs#138](https://github.com/dfinity/ic-hs/issues/138)) * [`808ba08b`](dfinity/ic-hs@808ba08) split Multiple controllers tests ([dfinity/ic-hs#149](https://github.com/dfinity/ic-hs/issues/149))
dfinity-bot
added a commit
that referenced
this pull request
Mar 2, 2023
## Changelog for ic-hs: Branch: master Commits: [dfinity/ic-hs@927d8152...bdaaa321](dfinity/ic-hs@927d815...bdaaa32) * [`54dcdd0c`](dfinity/ic-hs@54dcdd0) .github/workflows/release.yml: only sync github pages on linux ([dfinity/ic-hs#143](https://github.com/dfinity/ic-hs/issues/143)) * [`81ac2e9c`](dfinity/ic-hs@81ac2e9) .github/workflows/release.yml: fix github-pages-deploy-action version ([dfinity/ic-hs#144](https://github.com/dfinity/ic-hs/issues/144)) * [`09a7b445`](dfinity/ic-hs@09a7b44) fix broken link in README ([dfinity/ic-hs#145](https://github.com/dfinity/ic-hs/issues/145)) * [`b393d8cb`](dfinity/ic-hs@b393d8c) .github/workflows/release.yml: skip coverage job on darwin ([dfinity/ic-hs#146](https://github.com/dfinity/ic-hs/issues/146)) * [`55870466`](dfinity/ic-hs@5587046) split haskell modules to reduce memory usage ([dfinity/ic-hs#142](https://github.com/dfinity/ic-hs/issues/142)) * [`6ddff2e4`](dfinity/ic-hs@6ddff2e) add httpbin implementation in Rust, bump nixpkgs, and sync universal_canister with ic monorepo ([dfinity/ic-hs#138](https://github.com/dfinity/ic-hs/issues/138)) * [`808ba08b`](dfinity/ic-hs@808ba08) split Multiple controllers tests ([dfinity/ic-hs#149](https://github.com/dfinity/ic-hs/issues/149)) * [`bdaaa321`](dfinity/ic-hs@bdaaa32) bump cachix/install-nix-action to v20 ([dfinity/ic-hs#150](https://github.com/dfinity/ic-hs/issues/150))
mergify bot
pushed a commit
that referenced
this pull request
Mar 2, 2023
## Changelog for ic-hs: Branch: master Commits: [dfinity/ic-hs@927d8152...bdaaa321](dfinity/ic-hs@927d815...bdaaa32) * [`54dcdd0c`](dfinity/ic-hs@54dcdd0) .github/workflows/release.yml: only sync github pages on linux ([dfinity/ic-hs#143](https://github.com/dfinity/ic-hs/issues/143)) * [`81ac2e9c`](dfinity/ic-hs@81ac2e9) .github/workflows/release.yml: fix github-pages-deploy-action version ([dfinity/ic-hs#144](https://github.com/dfinity/ic-hs/issues/144)) * [`09a7b445`](dfinity/ic-hs@09a7b44) fix broken link in README ([dfinity/ic-hs#145](https://github.com/dfinity/ic-hs/issues/145)) * [`b393d8cb`](dfinity/ic-hs@b393d8c) .github/workflows/release.yml: skip coverage job on darwin ([dfinity/ic-hs#146](https://github.com/dfinity/ic-hs/issues/146)) * [`55870466`](dfinity/ic-hs@5587046) split haskell modules to reduce memory usage ([dfinity/ic-hs#142](https://github.com/dfinity/ic-hs/issues/142)) * [`6ddff2e4`](dfinity/ic-hs@6ddff2e) add httpbin implementation in Rust, bump nixpkgs, and sync universal_canister with ic monorepo ([dfinity/ic-hs#138](https://github.com/dfinity/ic-hs/issues/138)) * [`808ba08b`](dfinity/ic-hs@808ba08) split Multiple controllers tests ([dfinity/ic-hs#149](https://github.com/dfinity/ic-hs/issues/149)) * [`bdaaa321`](dfinity/ic-hs@bdaaa32) bump cachix/install-nix-action to v20 ([dfinity/ic-hs#150](https://github.com/dfinity/ic-hs/issues/150))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hope I did all the grunt work here. Nothing seems to be broken (besides that
isandlikeare gone). Andreas, if this goes the right direction, then wecan either merge this (and you can do the type system improvements separately),
or just do it on this branch.