Fork Sync: Update from parent repository #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eventually we want to get to a point where we can remove OpenCV from the internals of cscore. The start to doing that is converting the existing CvSource and CvSink methods to RawFrame. For CvSource, this is 100% a free operation. We can do everything the existing code could have done (with one small exception we can fairly easily fix). For CvSink, by defaut this change would incur one extra copy, but no extra allocations. A set of direct methods were added to CvSink to add a method to avoid this extra copy.
As State is mutable, this avoids accidental modification of the passed-in object by the caller modifying the return value.
This allows creating subscribers that aren't communicated with the network.
Also don't require Enter for editing game data or match time.
We need fmtlib 10.2.1 to work around a compiler bug. Also, reducing the number of jobs is no longer required with Actions runner upgrades.
… not configured (#6417) This is an unrecoverable condition, so always terminate.
On Rio, we simply want to restart the robot program as quickly as possible, and don't want to risk a hang somewhere that will keep that from happening. The main downside of this is it won't wait for threads to finish (e.g. data logs won't get a final flush).
That's just a system with no back-EMF.
LinearSystemId's linear system factories throw on negative feedforward gains, but SysId can compute the feedback gains just fine in that case. Now we construct the system manually instead. Fixes #6423.
We don't need to generate a core dump here if core dumps are enabled.
…pace (#6468) When low on space, a log file won't be created. This is detected as a "deletion", and the DataLog thread will continously try to create a log, fail to do so because of low space, detect it as a "deletion", and do so in a loop. If there's not enough space, the DataLog will be marked as stopped, preventing this infinite loop. Calls to start() will hit this code path and mark it as stopped again.
Uses https://github.com/bminor/xz to work around suspended repository. We will revert this once vcpkg updates to point to an accessible repo.
This allows consuming allwpilib via FetchContent.
Avoids need to click twice to get to contributing.md.
Change hamming distance to 1, add comment about memory usage.
Uses getUsableSpace in Java, matching how C++ determines available space (C++ calls it available, but they mean the same thing.) This fixes a bug where logs wouldn't get deleted due to incorrect available space detection. The DataLog thread now also checks if the state was marked as stopped after a call to StartLogFile.
This implementation uses a tolerance in the same units as the measure it checks.
Also add waitTime() factory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.