winch: Use Reg where appropriate in the Masm
#7002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is a small refactoring to some of the MacroAssembler functions to use `Reg` instead of `RegImm` where appropriate (e.g. when the operand is a destination). @elliottt pointed this out while working on bytecodealliance#6982 This change also changes the signature of `float_abs` and `float_neg`, which can be simplified to take a single register.
saulecabrera
requested review from
abrown and
elliottt
and removed request for
a team and
abrown
Subscribe to Label Action
This issue or pull request has been labeled: "winch"
Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
eduardomourar
pushed a commit
to eduardomourar/wasmtime
that referenced
this pull request
Sep 13, 2023
This change is a small refactoring to some of the MacroAssembler functions to use `Reg` instead of `RegImm` where appropriate (e.g. when the operand is a destination). @elliottt pointed this out while working on bytecodealliance#6982 This change also changes the signature of `float_abs` and `float_neg`, which can be simplified to take a single register.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is a small refactoring to some of the MacroAssembler functions to use
Reginstead ofRegImmwhere appropriate (e.g. when the operand is a destination).@elliottt pointed this out while working on #6982
This change also changes the signature of
float_absandfloat_neg, which can be simplified to take a single register.