winch: Support abs and neg for f32 and f64 on x64 #6982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Nick Fitzgerald <[email protected]>
saulecabrera
reviewed
Sep 8, 2023
There was a problem hiding this comment.
Generally LGTM, thanks! A couple of minor comments:
- Spec tests: we could copy the
<f32|f64>.abstest cases fromtests/spec_testsuite/<f32|f64>_bitwise.wastintotests/misc_testsuite/winch/<f32|f64>_bitwise.wastto get test for these instructions additional to the filetests. This process is a bit manual at the moment, unfortunately, but the idea is that once Winch reaches support for Core Wasm this process should go away almost entirely. - Add
f32.absandf64.absto the list of supported instructions to the differential fuzzer in https://github.com/bytecodealliance/wasmtime/blob/main/fuzz/fuzz_targets/differential.rs#L289 (I run the differential fuzzer locally from time to time. The idea is to enable fuzzing by default once Winch reaches parity with Core Wasm).
Subscribe to Label Action
This issue or pull request has been labeled: "winch"
Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
elliottt
changed the title
elliottt
force-pushed
the
trevor/winch-f32abs
branch
from
405d17c
to
bf65152
Compare
Subscribe to Label Actioncc @fitzgen
This issue or pull request has been labeled: "fuzzing"
Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
saulecabrera
added a commit
to saulecabrera/wasmtime
that referenced
this pull request
Sep 11, 2023
This change is a small refactoring to some of the MacroAssembler functions to use `Reg` instead of `RegImm` where appropriate (e.g. when the operand is a destination). @elliottt pointed this out while working on bytecodealliance#6982 This change also changes the signature of `float_abs` and `float_neg`, which can be simplified to take a single register.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 12, 2023
This change is a small refactoring to some of the MacroAssembler functions to use `Reg` instead of `RegImm` where appropriate (e.g. when the operand is a destination). @elliottt pointed this out while working on #6982 This change also changes the signature of `float_abs` and `float_neg`, which can be simplified to take a single register.
alexcrichton
pushed a commit
that referenced
this pull request
Sep 12, 2023
* winch: Support f32.abs and f64.abs on x64 Co-authored-by: Nick Fitzgerald <[email protected]> * Add an implementation of f32.neg and f64.neg * Enable spec tests for winch with f{32,64}.{neg,abs} * Enable differential fuzzing for f{32,64}.{neg,abs} for winch * Comments from code review --------- Co-authored-by: Nick Fitzgerald <[email protected]>
eduardomourar
pushed a commit
to eduardomourar/wasmtime
that referenced
this pull request
Sep 13, 2023
) * winch: Support f32.abs and f64.abs on x64 Co-authored-by: Nick Fitzgerald <[email protected]> * Add an implementation of f32.neg and f64.neg * Enable spec tests for winch with f{32,64}.{neg,abs} * Enable differential fuzzing for f{32,64}.{neg,abs} for winch * Comments from code review --------- Co-authored-by: Nick Fitzgerald <[email protected]>
eduardomourar
pushed a commit
to eduardomourar/wasmtime
that referenced
this pull request
Sep 13, 2023
This change is a small refactoring to some of the MacroAssembler functions to use `Reg` instead of `RegImm` where appropriate (e.g. when the operand is a destination). @elliottt pointed this out while working on bytecodealliance#6982 This change also changes the signature of `float_abs` and `float_neg`, which can be simplified to take a single register.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for
f32.abs,f64.abs,f32.neg, andf64.negto winch. Additionally, this adds agpr_to_xmmfunction to the x64 backend to allow loading a constant and moving it to an xmm register. It also reservesxmm15as the scratch xmm register.