This repository has been archived by the owner on Jan 12, 2021. It is now read-only.
feat: Add retry with backoff to requests #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a bit more tolerance to network outages etc. If a 40x status code is recieved from the API it will not retry as this indicates a bad request – so no need to keep sening the same request. There were no end-to-end tests predating this feature so I added some. Fixes bugsnag/webpack-bugsnag-plugins#17.
snmaynard
reviewed
Nov 28, 2018
Cawllec
approved these changes
Dec 4, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a bit more tolerance to network outages etc. If a 40x status code is recieved from the API it will not retry as this indicates a bad request – so no need to keep sening the same request.
There were no end-to-end tests predating this feature so I added some.
Fixes bugsnag/webpack-bugsnag-plugins#17.