Skip to content
This repository has been archived by the owner on Jan 12, 2021. It is now read-only.

feat: Add retry with backoff to requests #26

Merged
merged 5 commits into from
Dec 4, 2018
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 2 additions & 13 deletions index.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
'use strict';

const fs = require('graceful-fs');
const request = require('request');
const request = require('./lib/request');
const path = require('path');
const os = require('os');

Expand Down Expand Up @@ -330,18 +330,7 @@ function sendRequest(args) {
// { options, formData }
const options = args.options
const formData = args.formData
return new Promise((resolve, reject) => {
request.post({
url: options.endpoint,
formData,
}, function (err, res, body) {
if (err || res.statusCode !== 200) {
reject(err || new Error(`${res.statusMessage} (${res.statusCode}) - ${body}`));
} else {
resolve(options);
}
});
});
return request(options.endpoint, formData).then(() => options)
}

/**
Expand Down
34 changes: 34 additions & 0 deletions lib/request.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
'use strict'

const request = require('request')
const Backoff = require('backo')
bengourley marked this conversation as resolved.
Show resolved Hide resolved
const MAX_ATTEMPTS = 5
const MIN_BACKOFF_INTERVAL = process.env.BUGSNAG_MIN_BACKOFF_INTERVAL || 500
const MAX_BACKOFF_INTERVAL = process.env.BUGSNAG_MAX_BACKOFF_INTERVAL || 5000

module.exports = (url, formData) => {
return new Promise((resolve, reject) => {
const backoff = new Backoff({ min: MIN_BACKOFF_INTERVAL, max: MAX_BACKOFF_INTERVAL })

const onSuccess = () => resolve()
const onError = (err) => {
if (backoff.attempts >= MAX_ATTEMPTS - 1) return reject(err)
if (err.statusCode >= 400 && err.statusCode < 500) return reject(err)
setTimeout(() => req(url, formData, onError, onSuccess), backoff.duration())
}

req(url, formData, onError, onSuccess)
})
}

const req = (url, formData, onError, onSuccess) => {
request.post({ url, formData }, function (err, res, body) {
if (err || res.statusCode !== 200) {
err = err || new Error(`${res.statusMessage} (${res.statusCode}) - ${body}`)
if (res.statusCode) err.statusCode = res.statusCode
onError(err)
} else {
onSuccess()
}
})
}
Loading