Skip to content
This repository has been archived by the owner on Jan 12, 2021. It is now read-only.

feat: Add retry with backoff to requests #26

Merged
merged 5 commits into from
Dec 4, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 2 additions & 13 deletions index.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
'use strict';

const fs = require('graceful-fs');
const request = require('request');
const request = require('./lib/request');
const path = require('path');
const os = require('os');

Expand Down Expand Up @@ -330,18 +330,7 @@ function sendRequest(args) {
// { options, formData }
const options = args.options
const formData = args.formData
return new Promise((resolve, reject) => {
request.post({
url: options.endpoint,
formData,
}, function (err, res, body) {
if (err || res.statusCode !== 200) {
reject(err || new Error(`${res.statusMessage} (${res.statusCode}) - ${body}`));
} else {
resolve(options);
}
});
});
return request(options.endpoint, formData).then(() => options)
}

/**
Expand Down
32 changes: 32 additions & 0 deletions lib/request.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
'use strict'

const request = require('request')
const MAX_ATTEMPTS = 5
const RETRY_INTERVAL = process.env.BUGSNAG_RETRY_INTERVAL || 1000

module.exports = (url, data) => {
return new Promise((resolve, reject) => {
let attempts = 0
const maybeRetry = (err) => {
attempts++
if (err && err.isRetryable && attempts < MAX_ATTEMPTS) return setTimeout(go, RETRY_INTERVAL)
return reject(err)
}
const go = () => send(url, data, resolve, maybeRetry)
go()
})
}

const send = (url, formData, onSuccess, onError) => {
request.post({ url, formData }, (err, res, body) => {
if (err || res.statusCode !== 200) {
err = err || new Error(`${res.statusMessage} (${res.statusCode}) - ${body}`)
if (res.statusCode < 400 || res.statusCode >= 500) {
err.isRetryable = true
}
onError(err)
} else {
onSuccess()
}
})
}
Loading