Allow consolidated-events ^2.0.0 #256
Conversation
None of the changes affect how consolidated-events is used in react-waypoint. Changelog: - Now built with rollup ([#8](lencioni/consolidated-events#8)) - Deprecated `removeEventListener` export removed ([#13](lencioni/consolidated-events#13)) - Passive event listener test is now removed after being added ([#11](lencioni/consolidated-events#11)) - Reduced bundle size impact by replacing a class with a function ([#12](lencioni/consolidated-events#12))
| @@ -67,7 +67,7 @@ | |||
| "scrollspy" | |||
| ], | |||
| "dependencies": { | |||
| "consolidated-events": "^1.1.0", | |||
| "consolidated-events": "^1.1.0 || ^2.0.0", | |||
There was a problem hiding this comment.
Why didn’t you just upgrade to 2.0.0?
There was a problem hiding this comment.
I want to make it easier for people who have to deal with breaking changes in consolidated-events to upgrade more gradually. Also, there's no reason in this package for us to not support v1, so might as well.
|
@lencioni did you mean to include the changelog stuff in a different PR? |
|
@MatthewHerbst I'm not sure I understand your question. Do you mean updating the changelog for react-waypoint? I've been doing that at publish time lately. |
|
@lencioni No problem. I was just confused why there was changelog stuff listed in the OP for this PR but that the PR doesn't touch the changelog. |
|
That's the changelog for the consolidated-events version difference to help give reviewers more context about what this change actually entails. |
None of the changes affect how consolidated-events is used in
react-waypoint.
Changelog:
removeEventListenerexport removed (#13)