[core] make it possible to use zero operation count again. (#1382) #1384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…kcooper#1382) Previously, if you defined maxexecutiontime and not defined operationcount parameter (or set operationcount=0), then you were able to run YCSB for a given period of time and measure the number of operations you get during the load test. Since brianfrankcooper#1323 was merged, it it not possible to use operationcount=0, as the thread count will be set to 0 in this case and no client thread will be created. This PR makes it possible to use operationcount=0 again.
|
I don't think this build error is related to anything I did... is it possible to re-trigger the CI build? |
|
Yes, but I need to make sure the failure was transient. It showed up in a bunch of places. |
|
okay it's not transient, but just happens on Travis. they must be futzing about with maven mirrors again. :( In any case I ran through the tests locally and they look fine. |
hse-project
pushed a commit
to hse-project/hse-ycsb
that referenced
this pull request
Apr 17, 2020
…kcooper#1384) Previously, if you defined maxexecutiontime and not defined operationcount parameter (or set operationcount=0), then you were able to run YCSB for a given period of time and measure the number of operations you get during the load test. Since brianfrankcooper#1323 was merged, it it not possible to use operationcount=0, as the thread count will be set to 0 in this case and no client thread will be created. This PR makes it possible to use operationcount=0 again. fixes brianfrankcooper#1382 (cherry picked from commit 650eee2)
hse-project
pushed a commit
to hse-project/hse-ycsb
that referenced
this pull request
Apr 17, 2020
….0-patch to hse-0.17.0 * commit '6120a6b8cc2191313fdc159270791fdd4fb3b4e3': mark release 0.17.0 in Makefile and spec file mark release 0.17.0 in bindings [core] make it possible to use zero operation count again. (brianfrankcooper#1384) convert recordcount and operationcount from int to long commit Makefile and spec file temp disable bindings due to issues with nexus mirror combined commit for hse
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solving #1382
Previously, if you defined maxexecutiontime and not defined operationcount
parameter (or set operationcount=0), then you were able to run YCSB for a
given period of time and measure the number of operations you get during
the load test.
Since #1323 was merged, it it not possible to use operationcount=0, as
the thread count will be set to 0 in this case and no client thread will
be created. This PR makes it possible to use operationcount=0 again.