Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

not possible to use zero operation count #1382

Closed
symat opened this issue Jan 6, 2020 · 1 comment
Closed

not possible to use zero operation count #1382

symat opened this issue Jan 6, 2020 · 1 comment

Comments

@symat
Copy link
Contributor

symat commented Jan 6, 2020

Previously, if you defined maxexecutiontime and not defined operationcount parameter (or set operationcount=0), then you were able to run YCSB for a given period of time and measure the number of operations you get during the load test.

Since #1323 was merged, it it not possible to use operationcount=0, as the thread count will be set to 0 in this case and no client thread will be created:

if (threadcount > opcount){
threadcount = opcount;
System.out.println("Warning: the threadcount is bigger than recordcount, the threadcount will be recordcount!");
}

The solution would be to change the is statement to: if (threadcount > opcount && opcount > 0)

What do you think?
(should I create a PR?)

@busbey
Copy link
Collaborator

busbey commented Jan 6, 2020

Yes please, that solution sounds great.

symat added a commit to symat/YCSB that referenced this issue Jan 8, 2020
…kcooper#1382)

Previously, if you defined maxexecutiontime and not defined operationcount
parameter (or set operationcount=0), then you were able to run YCSB for a
given period of time and measure the number of operations you get during
the load test.

Since brianfrankcooper#1323 was merged, it it not possible to use operationcount=0, as
the thread count will be set to 0 in this case and no client thread will
be created. This PR makes it possible to use operationcount=0 again.
@busbey busbey closed this as completed in 650eee2 Jan 31, 2020
hse-project pushed a commit to hse-project/hse-ycsb that referenced this issue Apr 17, 2020
…kcooper#1384)

Previously, if you defined maxexecutiontime and not defined operationcount
parameter (or set operationcount=0), then you were able to run YCSB for a
given period of time and measure the number of operations you get during
the load test.

Since brianfrankcooper#1323 was merged, it it not possible to use operationcount=0, as
the thread count will be set to 0 in this case and no client thread will
be created. This PR makes it possible to use operationcount=0 again.

fixes brianfrankcooper#1382
(cherry picked from commit 650eee2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants