[core] limit number of client threads based on op count. #1323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianfrankcooper#1212 The YCSB readme is as the following, which is a little misleading.Because we can't use '-p durability=false' to disable durability. Instead it worked when I used '-p durability=SKIP_WAL'. The readme should be written more clearly. durability: Whether or not writes should be appended to the WAL. Bypassing the WAL can improve throughput but data cannot be recovered in the event of a crash. The default is true.
It's related to issue brianfrankcooper#1176
update core.client.java
To solve issue brianfrankcooper#1176
busbey
changed the title
busbey
approved these changes
Sep 7, 2019
Closed
symat
added a commit
to symat/YCSB
that referenced
this pull request
Jan 8, 2020
…kcooper#1382) Previously, if you defined maxexecutiontime and not defined operationcount parameter (or set operationcount=0), then you were able to run YCSB for a given period of time and measure the number of operations you get during the load test. Since brianfrankcooper#1323 was merged, it it not possible to use operationcount=0, as the thread count will be set to 0 in this case and no client thread will be created. This PR makes it possible to use operationcount=0 again.
busbey
pushed a commit
that referenced
this pull request
Jan 31, 2020
Previously, if you defined maxexecutiontime and not defined operationcount parameter (or set operationcount=0), then you were able to run YCSB for a given period of time and measure the number of operations you get during the load test. Since #1323 was merged, it it not possible to use operationcount=0, as the thread count will be set to 0 in this case and no client thread will be created. This PR makes it possible to use operationcount=0 again. fixes #1382
hse-project
pushed a commit
to hse-project/hse-ycsb
that referenced
this pull request
Apr 17, 2020
…kcooper#1384) Previously, if you defined maxexecutiontime and not defined operationcount parameter (or set operationcount=0), then you were able to run YCSB for a given period of time and measure the number of operations you get during the load test. Since brianfrankcooper#1323 was merged, it it not possible to use operationcount=0, as the thread count will be set to 0 in this case and no client thread will be created. This PR makes it possible to use operationcount=0 again. fixes brianfrankcooper#1382 (cherry picked from commit 650eee2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To solve issue #1176