Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ads History should be displayed in reverse chronological order #6757

Closed
jsecretan opened this issue Nov 4, 2019 · 1 comment · Fixed by brave/brave-core#4109
Closed

Ads History should be displayed in reverse chronological order #6757

jsecretan opened this issue Nov 4, 2019 · 1 comment · Fixed by brave/brave-core#4109
Assignees
@tmancey
Labels
feature/ads priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.4.x - Release

Comments

@jsecretan
Copy link

Description

Currently Ads History is shown with older entries toward the top. It should be instead organized with the most recent dates first.
@jsecretan jsecretan added priority/P3 The next thing for us to work on. It'll ride the trains. feature/ads labels Nov 4, 2019
@tmancey tmancey self-assigned this Nov 29, 2019
@tmancey tmancey mentioned this issue Nov 30, 2019
Merged
32 tasks
@tmancey tmancey mentioned this issue Dec 5, 2019
Closed
@tmancey tmancey added this to the 1.4.x - Nightly milestone Dec 9, 2019
@btlechowski btlechowski mentioned this issue Jan 15, 2020
Closed
@tmancey tmancey mentioned this issue Jan 24, 2020
Closed
This was referenced Feb 4, 2020
Closed
Closed
@LaurenWags
Copy link
Member

LaurenWags commented Feb 12, 2020 •
edited by btlechowski
Loading

Verified passed with

Brave 1.4.85 Chromium: 80.0.3987.87 (Official Build) beta (64-bit)
Revision 449cb163497b70dbf98d389f54e38e85d4c59b43-refs/branch-heads/3987@{#801}
OS macOS Version 10.14.6 (Build 18G103)

Reproduced on 1.3.115:
Screen Shot 2020-02-12 at 4 47 18 PM

Confirmed changed with 1.4.85:
Screen Shot 2020-02-12 at 4 37 59 PM

Verification passed on

Brave 1.4.84 Chromium: 80.0.3987.87 (Official Build) beta (64-bit)
Revision 449cb163497b70dbf98d389f54e38e85d4c59b43-refs/branch-heads/3987@{#801}
OS Ubuntu 18.04 LTS

Verified most recent ad entries are at the top.
image

Verified that within a day, ads are also shown in chronological order, most recent add being at the top
image

Verification passed on

Brave 1.4.85 Chromium: 80.0.3987.87 (Official Build) beta (64-bit)
Revision 449cb163497b70dbf98d389f54e38e85d4c59b43-refs/branch-heads/3987@{#801}
OS Windows 7 Service Pack 1 (Build 7601.24544)

image

@tmancey tmancey mentioned this issue Feb 14, 2020
Closed
@kjozwiak kjozwiak mentioned this issue Feb 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmancey tmancey

Labels
feature/ads priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Milestone
1.4.x - Release
Development

Successfully merging a pull request may close this issue.

Ads History should be displayed in reverse chronological order brave/brave-core
6 participants
@jsecretan @tmancey @masparrow @LaurenWags @btlechowski @GeetaSarvadnya