Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ads history is limited to 99 entries - follow up to 5863 #8046

Closed
LaurenWags opened this issue Feb 4, 2020 · 2 comments
Closed

Ads history is limited to 99 entries - follow up to 5863 #8046

LaurenWags opened this issue Feb 4, 2020 · 2 comments

Comments

@LaurenWags
Copy link
Member

Description

Originally logged with #5863

Per discussion, logging this follow up issue so #5863 can be retested with 1.4.x milestone where blocking issue #7743 is fixed by #6757

Steps to Reproduce

follow steps in #5863 (see @btlechowski for file if needed)

Actual result:

Only up to 99 ads viewed during 7 days are shown in the history

Expected result:

All ads viewed during 7 days should be shown in the history

Reproduces how often:

easily

Brave version (brave://version info)

1.3.x

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the dev channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @brave/legacy_qa

@LaurenWags LaurenWags added bug priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/include feature/ads labels Feb 4, 2020
@LaurenWags LaurenWags added this to the 1.4.x - Dev milestone Feb 4, 2020
@LaurenWags
Copy link
Member Author

Closing this issue as its blocking issue #7743 is fixed by #6757 in the 1.4.x milestone

@btlechowski
Copy link

btlechowski commented Feb 12, 2020

Verification passed on

Brave 1.4.85 Chromium: 80.0.3987.87 (Official Build) beta (64-bit)
Revision 449cb163497b70dbf98d389f54e38e85d4c59b43-refs/branch-heads/3987@{#801}
OS Windows 7 Service Pack 1 (Build 7601.24544)

Talked to @tmancey about possible test cases. Max entries in ads shown history is 560.

  • Used 560 entries in ads history and verified all 560 entries are shown in ads history
    client.zip

image
image

Steps:

  1. Clean profile
  2. Enable rewards
  3. View an ad
  4. Close Brave
  5. copy client.json to [PROFILE]\Default\ads_service\ Note: You need to unpack client.zip
  6. Run Brave
  7. Open brave://rewards
  8. Reload the page few times to shown the generated ads history

Verified passed with

Brave 1.4.85 Chromium: 80.0.3987.87 (Official Build) beta (64-bit)
Revision 449cb163497b70dbf98d389f54e38e85d4c59b43-refs/branch-heads/3987@{#801}
OS macOS Version 10.14.6 (Build 18G103)
  • Verified scenarios above using the files/steps provided by @btlechowski and confirmed over 99 entries are shown in Ads History

Screen Shot 2020-02-12 at 4 38 14 PM

Verification passed on

Brave 1.4.84 Chromium: 80.0.3987.87 (Official Build) beta (64-bit)
Revision 449cb163497b70dbf98d389f54e38e85d4c59b43-refs/branch-heads/3987@{#801}
OS Ubuntu 18.04 LTS

Verified above scenarios

image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants