Incomplete Ads History

[jonathansampson]

Description

Brave's Ads History view is showing an incomplete list of ads history.

Steps to Reproduce

1. Navigate to about:rewards
2. Click '7-day ads history' within Ads panel

Actual result:

A subset of ads shown over the previous 7 days is displayed

Expected result:

A complete list of ads shown over the previous 7 days are displayed

Reproduces how often:

Always

Brave version (brave://version info)

1.3.115

Version/Channel Information:

• Can you reproduce this issue with the current release? Yes
• Can you reproduce this issue with the beta channel? TBD
• Can you reproduce this issue with the dev channel? TBD
• Can you reproduce this issue with the nightly channel? TBD

Miscellaneous Information:

While the page displays only a subset of all ads shown over the past 7 days, it does display all ads from the adsHistory in localStorage. The issue appears to be with recording ads shown, and not with displaying the history.

Only 2 ads are listed from 6 days ago. I have ads set to 4/hr, and see them often. Thought I don't recall having seen one in the past few hours.

[jonathansampson]

I just got an ad, but found that it wasn't included in the 7-Day History.

[Sh1d0w]

Hey @jonathansampson do you think the issue I've reported yesterday is related #8202

I got no response to it so far, yet a lot of users are experiencing the same since the latest update.

[jonathansampson]

@Sh1d0w I don't believe so; see my response here.

[jonathansampson]

This user also appears to have an incomplete history of ads displayed:

[btlechowski]

@jonathansampson Could be related to #7743, which is fixed in 1.4.x.

In 1.4.x Ads history got a big rewrite and everything works much better.

[jonathansampson]

@btlechowski Note, my adsHistory state also didn't contain more than the 2 ads shown. Is that known to be related to #7743? I kept getting ads, but they weren't being added to adsHistory in state.

[tmancey]

@jonathansampson @Sh1d0w Closing as this issue is fixed by #6757 and #7869, we are uplifting to 1.4 and 1.5 for when 1.4 is released. Thanks