Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decouple filter for 'Last 7 Days' of Brave Ads history #6870

Closed
masparrow opened this issue Nov 11, 2019 · 1 comment
Closed

Decouple filter for 'Last 7 Days' of Brave Ads history #6870

masparrow opened this issue Nov 11, 2019 · 1 comment
Labels
dev-concern feature/ads QA/No
Milestone
Closed / Dupe / I...

Comments

@masparrow
Copy link

Description

The code for finding the last seven days of Ads to show in the Rewards Settings page can now be refactored into a stand alone filter (see 'AdHistoryFilter')

This makes it unit testable, and allows more filters to be applied in the future as needed.
@masparrow masparrow mentioned this issue Nov 11, 2019
Merged
32 tasks
@tmancey tmancey changed the title Create a filter for the last seven days of Ads Decouple business logic for filtering of last 7 days of Brave Ads to use a filter Jan 21, 2020
@tmancey tmancey changed the title Decouple business logic for filtering of last 7 days of Brave Ads to use a filter Decouple filter for 'Last 7 Days' of Brave Ads history Jan 21, 2020
@tmancey tmancey added the QA/No label Jan 24, 2020
@tmancey
Copy link
Contributor

tmancey commented Jan 24, 2020

Closing issue as fixed as part of #6757

@tmancey tmancey closed this as completed Jan 24, 2020
@bbondy bbondy added this to the Closed / Invalid milestone Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dev-concern feature/ads QA/No
Projects
None yet
Milestone
Closed / Dupe / Invalid
Development

No branches or pull requests
4 participants
@bbondy @tmancey @rebron @masparrow