Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move security and privacy higher in brave://settings #16470

Closed
2 tasks done
diracdeltas opened this issue Jun 16, 2021 · 3 comments · Fixed by brave/brave-core#9243
Closed
2 tasks done

Move security and privacy higher in brave://settings #16470

diracdeltas opened this issue Jun 16, 2021 · 3 comments · Fixed by brave/brave-core#9243
Assignees

Comments

@diracdeltas
Copy link
Member

diracdeltas commented Jun 16, 2021

The entire Security and Privacy section of settings should be moved so it's not behind the drop-down on the sidebar. If needed we can switch it with the Safety Check menu item which isn't very important.

  • Move Privacy and security section above the fold under Social media blocking
  • Move Safety check below the fold below Downloads and above Help tips

Expected Result - Updated Design and Text

New placement for Privacy and security section under Social media blocking

screen_shot_2021-06-24_at_10 50 59_pm

New placement for Safety check below Downloads and above Help tips

screen_shot_2021-06-24_at_10 51 16_pm

Current Design for QA Reference

Brave 1.26.67 Chromium: 91.0.4472.114 (Official Build) (arm64)
Revision 4bb19460e8d88c3446b360b0df8fd991fee49c0b-refs/branch-heads/4472@{#1496}
OS macOS Version 12.0 (Build 21A5248p)

Screen Shot 2021-06-25 at 12 40 01 PM

@diracdeltas diracdeltas added priority/P3 The next thing for us to work on. It'll ride the trains. OS/Desktop labels Jun 16, 2021
@diracdeltas diracdeltas self-assigned this Jun 16, 2021
@fmarier
Copy link
Member

fmarier commented Jun 16, 2021

Agreed. Safety Check is at the moment (at least until we implement #12001) pretty useless in Brave since it essentially just tells users that Safe Browsing is enabled.

@diracdeltas
Copy link
Member Author

we decided the text rewording will happen in a follow up

@stephendonner
Copy link

Verified PASSED with build

Brave 1.28.37 Chromium: 91.0.4472.124 (Official Build) nightly (x86_64)
Revision 7345a6d1bfcaff81162a957e9b7d52649fe2ac38-refs/branch-heads/4472_114@{#6}
OS macOS Version 11.4 (Build 20F71)

Confirmed Privacy & Security moved up below Social media blocking and above Sync, and Safety Check moved into Additional Settings, and it matches that in brave/brave-core#9243, and that various features and pref toggles/states worked, within both of those.

Example Example Example Example
Screen Shot 2021-06-29 at 3 48 07 PM Screen Shot 2021-06-29 at 3 48 17 PM Screen Shot 2021-06-29 at 3 52 32 PM Screen Shot 2021-06-29 at 3 52 40 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants