Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usage ping opt out doesn't work #16378

Closed
fmarier opened this issue Jun 12, 2021 · 5 comments
Closed

Usage ping opt out doesn't work #16378

fmarier opened this issue Jun 12, 2021 · 5 comments
Assignees
Labels
network/startup requests OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. privacy QA/No release-notes/exclude

Comments

@fmarier
Copy link
Member

fmarier commented Jun 12, 2021

We have a settings (default OFF) which claims to control both usage pings and crash reports:
Screenshot from 2021-06-11 19-13-42

However, requests to the stats endpoint (laptop-updates.brave.com) still take place despite this setting being turned off.

We should:

  • Ensure crash report setting only applies to crash reports.

Related issues:

@fmarier
Copy link
Member Author

fmarier commented Jun 16, 2021

There is also an issue open around improving the presentation of our various opt-outs in settings: #14269

@kkuehlz kkuehlz self-assigned this Jun 22, 2021
@rebron rebron added the design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. label Jun 23, 2021
@karenkliu
Copy link

(Refer to #14269 for the updated crash reporting text)

@rebron rebron removed the design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. label Jun 23, 2021
@kkuehlz
Copy link
Contributor

kkuehlz commented Jun 24, 2021

#16583 for creating the pref in local state

@rebron
Copy link
Collaborator

rebron commented Jul 12, 2021

@keur Is this resolved with this fix? #16583

@kkuehlz
Copy link
Contributor

kkuehlz commented Jul 12, 2021

Yep, and this is the PR. At first we weren't going to batch the UI with the logic change, but we ended up doing it. Forgot to update the issue. Closing brave/brave-core#9229

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
network/startup requests OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. privacy QA/No release-notes/exclude
Projects
None yet
Development

No branches or pull requests

5 participants