Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contextual reload icon on Brave Rewards panel should be removed #1598

Closed
srirambv opened this issue Oct 15, 2018 · 9 comments · Fixed by brave/brave-core#798
Closed

Contextual reload icon on Brave Rewards panel should be removed #1598

srirambv opened this issue Oct 15, 2018 · 9 comments · Fixed by brave/brave-core#798

Comments

@srirambv
Copy link
Contributor

Description

Donate to this site monthly has a reload button next to it in rewards panel that is not functional. Should be removed similar to help icon removed in #1472

Steps to Reproduce

  1. Enable rewards
  2. Add funds
  3. Visit a site and open rewards panel. Non functional reload icon is shown next to donate text

Actual result:

image

Expected result:

Icon should be reomved

Reproduces how often:

All the time

Brave version (chrome://version info)

Brave 0.55.14 Chromium: 70.0.3538.54 (Official Build) beta(64-bit)
Revision 4f8e578b6680574714e9ed3bb9f02922b4dde40d-refs/branch-heads/3538@{#937}
OS Linux

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?
    Yes
  • Does it reproduce on browser-laptop?
    No

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

@NejcZdovc
Copy link
Contributor

@srirambv this is an indicator that is recurring donation. We use same icon in tips table in settings page

image

@srirambv
Copy link
Contributor Author

@NejcZdovc to be honest its not very intuitive as to what the indicator is about. Using the reload button there, my initial thought was to refresh to see the donation. We should may be add a tool tip to explain what that is.

On the rewards panel the text is self explanatory that the donation is to be done monthly so there is no need for the icon. If we do need an icon there and on the tips table in settings page may be we should use something like this rather than the reload button icon

image

cc: @kjozwiak @LaurenWags @bradleyrichter

@NejcZdovc
Copy link
Contributor

cc @jenn-rhim

@LaurenWags
Copy link
Member

+1 to @srirambv comment - I also thought it was a reload button. It's almost identical to the browser reload icon:
screen shot 2018-10-16 at 9 09 03 am

I don't think we need an icon, but if we do one that's more similar to the icon from #1598 (comment) seems more appropriate to me.

@bradleyrichter
Copy link

This was going to be removed. Just didn't make the issue list yet.

@NejcZdovc please remove it in all instances and if necessary, we will create a new icon later.

@NejcZdovc
Copy link
Contributor

sure we can do that

@kjozwiak
Copy link
Member

Adding from #1620 which was closed in favour of this. When QAing, we'll need to make sure that the following scenario as been addressed as well.

Under the direct donations modal, there's a refresh button next to Make this monthly which basically does the exact same thing as clicking on the checkbox. I think we should remove this as it's pretty confusing. In this context, I'm not sure if the "refresh" button is the correct image to use.

Similar to issue #1598.

Steps to Reproduce

  1. open dev or beta and enable rewards via brave://rewards
  2. once enabled, visit a website and make sure it's added into the contribution table
  3. visit the same website and click on the Rewards button in the URL -> Donate Now
  4. click on the refresh button next to Make this monthly a few times
  5. click on the checkmark/checkbox button next to Make this monthly a few times

Actual result:

randomrefreshbutton

@NejcZdovc NejcZdovc modified the milestones: 1.0, 0.56.x - Beta Oct 22, 2018
@NejcZdovc NejcZdovc self-assigned this Oct 24, 2018
@NejcZdovc NejcZdovc assigned jasonrsadler and unassigned NejcZdovc Oct 29, 2018
@bbondy bbondy modified the milestones: 0.57.x - Dev, 1.x Backlog Oct 30, 2018
@NejcZdovc NejcZdovc added the priority/P5 Not scheduled. Don't anticipate work on this any time soon. label Oct 30, 2018
@NejcZdovc
Copy link
Contributor

was closed by brave-ui, we still need to bump ui version and update it in core

@NejcZdovc NejcZdovc modified the milestones: 1.x Backlog, 0.59.x - Nightly Nov 4, 2018
NejcZdovc added a commit to brave/brave-core that referenced this issue Nov 4, 2018
@btlechowski
Copy link

btlechowski commented Dec 12, 2018

Verification passed on

Brave 0.58.11 Chromium: 71.0.3578.80 (Official Build) beta (64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Windows 7 x64

image

Verification passed on

Brave 0.58.11 Chromium: 71.0.3578.80 (Official Build) beta (64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Linux

screenshot from 2018-12-12 16-05-46

Verified passed with

Brave 0.58.11 Chromium: 71.0.3578.80 (Official Build) beta(64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Mac OS X

screen shot 2018-12-12 at 12 42 01 pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment