Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing the "Refresh" button under the donate modal #1620

Closed
kjozwiak opened this issue Oct 16, 2018 · 1 comment
Closed

Removing the "Refresh" button under the donate modal #1620

kjozwiak opened this issue Oct 16, 2018 · 1 comment
Labels
closed/duplicate Issue has already been reported closed/invalid

Comments

@kjozwiak
Copy link
Member

Description

Under the direct donations modal, there's a refresh button next to Make this monthly which basically does the exact same thing as clicking on the checkbox. I think we should remove this as it's pretty confusing. In this context, I'm not sure if the "refresh" button is the correct image to use.

Similar to issue #1598.

Steps to Reproduce

  1. open dev or beta and enable rewards via brave://rewards
  2. once enabled, visit a website and make sure it's added into the contribution table
  3. visit the same website and click on the Rewards button in the URL -> Donate Now
  4. click on the refresh button next to Make this monthly a few times
  5. click on the checkmark/checkbox button next to Make this monthly a few times

Actual result:

randomrefreshbutton

Expected result:

Personally think the refresh button should be removed in this case as it doesn't really make sense. There's already a clickable checkbox to the left. You basically have the same functionality on the left and right of the Make this monthly text.

Reproduces how often:

100% reproducible using the above STR.

Brave version (brave://version info)

Brave 0.55.14 Chromium: 70.0.3538.54 (Official Build) beta(64-bit)
Revision 4f8e578b6680574714e9ed3bb9f02922b4dde40d-refs/branch-heads/3538@{#937}
OS Mac OS X
Brave 0.56.4 Chromium: 70.0.3538.54 (Official Build) dev (64-bit)
Revision 4f8e578b6680574714e9ed3bb9f02922b4dde40d-refs/branch-heads/3538@{#937}
OS Mac OS X

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?

Yes, currently reproducible on both dev & beta builds

  • Does it reproduce on browser-laptop?

N/A

Additional Information

CCing @bradleyrichter

@NejcZdovc
Copy link
Contributor

let's close this one, because as part of #1598 we will remove all reload icons everywhere

@NejcZdovc NejcZdovc added the closed/duplicate Issue has already been reported label Oct 16, 2018
@NejcZdovc NejcZdovc modified the milestones: 0.56.x - Beta, Dupe / Invalid / Not actionable Oct 16, 2018
@bbondy bbondy removed this from the Dupe / Invalid / Not actionable milestone May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/duplicate Issue has already been reported closed/invalid
Projects
None yet
Development

No branches or pull requests

3 participants