Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contextual help icon on Brave Rewards Panel should be removed #1472

Closed
LaurenWags opened this issue Oct 9, 2018 · 2 comments · Fixed by brave/brave-core#409
Closed

contextual help icon on Brave Rewards Panel should be removed #1472

LaurenWags opened this issue Oct 9, 2018 · 2 comments · Fixed by brave/brave-core#409
Assignees
Labels

Comments

@LaurenWags
Copy link
Member

LaurenWags commented Oct 9, 2018

Description

There is an icon of an exclamation point in a circle on the Brave Rewards Panel that doesn't seem to have a purpose or link (it's not mentioned in the spec but it is implemented). Per discussion it should be removed.

Steps to Reproduce

  1. If not enabled, enable Rewards.
  2. Navigate to a site.
  3. Click on the BAT logo.

Actual result:

Next to 'Include in Brave Auto-Contribute' text note the icon.
screen shot 2018-10-09 at 4 07 17 pm

Expected result:

Icon should be removed.

Reproduces how often:

easy

Brave version (chrome://version info)

Brave 0.55.11 Chromium: 70.0.3538.35 (Official Build) beta(64-bit)
Revision 28dcb499844fa40c28d5f62e337876cb936f79f5-refs/branch-heads/3538@{#678}
OS Mac OS X

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds? yes
  • Does it reproduce on browser-laptop? n/a

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Additional Information

@LaurenWags LaurenWags added design A design change, especially one which needs input from the design team feature/rewards QA/Yes QA/Test-Plan-Specified labels Oct 9, 2018
@LaurenWags LaurenWags added this to the 1.0 (0.56.x) milestone Oct 9, 2018
@LaurenWags
Copy link
Member Author

Per discussion with @jenn-rhim this contextual help icon should be removed for 1.0. It was meant to explain include/exclude behavior but Jenn said we will see if this is self-explanatory.

@LaurenWags LaurenWags changed the title icon on Brave Rewards Panel needs link or purpose contextual help icon on Brave Rewards Panel should be removed Oct 9, 2018
@NejcZdovc NejcZdovc self-assigned this Oct 10, 2018
@NejcZdovc NejcZdovc modified the milestones: 1.0 (0.56.x), Releasable builds 0.55.x Oct 10, 2018
@LaurenWags
Copy link
Member Author

LaurenWags commented Oct 13, 2018

Verified passed with

Brave 0.55.13 Chromium: 70.0.3538.54 (Official Build) beta(64-bit)
Revision 4f8e578b6680574714e9ed3bb9f02922b4dde40d-refs/branch-heads/3538@{#937}
OS Mac OS X
  • Verified icon was removed

Verification Passed on

Brave 0.55.13 Chromium: 70.0.3538.54 (Official Build) beta (64-bit)
Revision 4f8e578b6680574714e9ed3bb9f02922b4dde40d-refs/branch-heads/3538@{#937}
OS Windows

Verification Passed on

Brave 0.55.14 Chromium: 70.0.3538.54 (Official Build) beta(64-bit)
Revision 4f8e578b6680574714e9ed3bb9f02922b4dde40d-refs/branch-heads/3538@{#937}
OS Linux

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants