Skip to content

Fix Squad continuation dispatch inputs - #1752

Merged
bradygaster merged 2 commits into
devfrom
squad/1751-fix-continuation-dispatch-inputs
Aug 20, 2026
Merged

Fix Squad continuation dispatch inputs#1752
bradygaster merged 2 commits into
devfrom
squad/1751-fix-continuation-dispatch-inputs

Conversation

@bradygaster

Copy link
Copy Markdown
Owner

Summary

Working as Booster (CI/CD Engineer).

  • fix merge continuation to call the prompt-visible dispatch_workflow shape with workflow_name: squad and nested inputs.command / inputs.issue_number
  • remove the silent cast workflow_dispatch default and document visible missing-input failures
  • require the continuation comment to target the parent epic
  • add static gates for destructive dispatch defaults and continuation payload/input-name drift

Closes #1751

Mechanism proven

Raw safe output from fixture run 32316227601 was only {"type":"dispatch_workflow"}. The agent artifact shows it called generic dispatch_workflow with top-level command and issue_number; the compiled schema expects workflow_name plus nested inputs, so the handler ignored those top-level keys and GitHub applied Squad's old cast default.

Validation

  • node scripts/check-workflow-input-interpolation.mjs
  • npx vitest run test/gh-aw-quality.test.ts ✅ 85 passed / 13 skipped
  • npm run build

Copilot AI lite review requested due to automatic review settings August 20, 2026 00:35
@github-actions

github-actions Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

🟡 Impact Analysis — PR #1752

Risk tier: 🟡 MEDIUM

📊 Summary

Metric Count
Files changed 6
Files added 1
Files modified 5
Files deleted 0
Modules touched 4

🎯 Risk Factors

  • 6 files changed (6-20 → MEDIUM)
  • 4 modules touched (2-4 → MEDIUM)

📦 Modules Affected

root (2 files)
  • workflows/squad-implement-worker.md
  • workflows/squad.md
scripts (1 file)
  • scripts/check-workflow-input-interpolation.mjs
squad-state (1 file)
  • .squad/decisions/inbox/booster-continuation-dispatch-inputs.md
tests (2 files)
  • test/gh-aw-implement-workflow.test.ts
  • test/gh-aw-quality.test.ts

This report is generated automatically for every PR. See #733 for details.

@github-actions

github-actions Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

🛫 PR Readiness Check

ℹ️ This comment updates on each push. Last checked: commit e9e185b

PR Scope: 🔧 Infrastructure

⚠️ 3 item(s) to address before review

Status Check Details
Single commit 2 commits — consider squashing before review
Not in draft Ready for review
Branch up to date Up to date with dev
Copilot review No Copilot review yet — it may still be processing
Changeset present No source files changed — changeset not required
Scope clean ⚠️ PR includes 1 .squad/ file(s) — ensure these are intentional
No merge conflicts No merge conflicts
Copilot threads resolved 1 unresolved Copilot thread(s) — fix and resolve before merging
CI passing All checks passing

Files Changed (6 files, +264 −23)

File +/−
.squad/decisions/inbox/booster-continuation-dispatch-inputs.md +39 −0
scripts/check-workflow-input-interpolation.mjs +79 −6
test/gh-aw-implement-workflow.test.ts +21 −2
test/gh-aw-quality.test.ts +95 −0
workflows/squad-implement-worker.md +13 −6
workflows/squad.md +17 −9

Total: +264 −23


This check runs automatically on every push. Fix any ❌ items and push again.
See CONTRIBUTING.md and PR Requirements for details.

@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Squad File Leakage Detected

The following .squad/ files were modified in this PR:

  • .squad/decisions/inbox/booster-continuation-dispatch-inputs.md

These files affect team routing, agent charters, and decisions.
If intentional, ensure approval from the team lead.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR hardens Squad’s merge-continuation flow by aligning the continuation dispatch payload with the prompt-visible dispatch_workflow schema (including workflow_name: squad and nested inputs), removing the silent workflow_dispatch default that masked missing inputs, and adding static regression gates to prevent future drift.

Changes:

  • Update workflows/squad-implement-worker.md merge-continuation instructions to dispatch Squad via dispatch_workflow using the nested inputs shape and to comment on the parent epic.
  • Remove workflow_dispatch.inputs.command’s destructive default in workflows/squad.md and document visible failures for missing command / issue_number.
  • Add automated guardrails in tests and a script gate to detect destructive dispatch defaults and continuation payload/input-name drift.
Show a summary per file
File Description
workflows/squad.md Removes the silent command: cast default and documents visible failure behavior for missing workflow_dispatch inputs.
workflows/squad-implement-worker.md Fixes merge continuation dispatch guidance to use the prompt-visible dispatch_workflow shape and target the parent epic for comments.
test/gh-aw-quality.test.ts Adds a regression suite asserting the continuation dispatch JSON shape matches Squad’s declared workflow_dispatch inputs.
scripts/check-workflow-input-interpolation.mjs Extends the static gate to flag destructive defaults for action-like workflow_dispatch inputs, in addition to bare input references in prompt bodies.
.squad/decisions/inbox/booster-continuation-dispatch-inputs.md Records the finding/decision/guardrail rationale for the dispatch contract and its enforcement.

Review details

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

  • Files reviewed: 5/5 changed files
  • Comments generated: 1
  • Review effort level: Lite

Comment on lines +228 to +231
Do not pass `command` or `issue_number` as top-level `dispatch_workflow`
arguments; gh-aw only forwards workflow inputs from the nested `inputs` object.
Never edit files or create a pull request in this mode. Stop after the `squad`
workflow is dispatched and the visible continuation comment is queued.
Closes #1751

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@bradygaster
bradygaster force-pushed the squad/1751-fix-continuation-dispatch-inputs branch from 72ee504 to 703eae0 Compare August 20, 2026 00:46
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix Squad merge continuation dispatch inputs

2 participants